Problem/Motivation

See http://api.drupal.org/api/drupal/core!modules!field_ui!field_ui.admin.in..., which is the (AFAIK) only implementation of this callback.

Steps to reproduce

Proposed resolution

Remaining tasks

Where to add the documentation?

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#13 1948572-13.patch726 bytesquietone

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Hm. Do you know what this region callback is supposed to do? I couldn't figure it out. I'm also not sure where we should document it.

joachim’s picture

joachim commented

Git blame tells us it was added in #616240: Make Field UI screens extensible from contrib - part II. It looks like it's responsible for telling a FormAPI pre-render callback which of the regions of the table to put a row into. On the manage fields page, the regions are 'main' and 'add_new'; on the display fields page, they are 'visible' and 'hidden'.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
quietone’s picture

quietone commented
Version: 9.3.x-dev » 10.0.x-dev
Category: Bug report » Task
Issue summary: View changes
Status: Active » Needs review
Issue tags: +Bug Smash Initiative
StatusFileSize
new 1948572-13.patch726 bytes

This came up as the random bug to triage in #bugsmash a few days.

Setting to a task because this is adding new documentation because are for 'incorrect or misleading documentation'.

#region_callback is only used in \Drupal\field_ui\Element\FieldUiTable::tablePreRender() 

          // Determine the region for the row.
          $region_name = call_user_func_array($row['#region_callback'], [&$row]);

I then made a patch for review.

joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

Thanks! Patch looks good.

(But surely missing documentation is a bug?)

  • catch committed 3cbed38 on 10.0.x 
    Issue #1948572 by quietone, joachim: Document #region_callback in Field...

  • catch committed 1e8dace on 9.4.x 
    Issue #1948572 by quietone, joachim: Document #region_callback in Field...
catch’s picture

catch
he/him
Primary language English
commented
Version: 10.0.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

If we're missing documentation for something that many people are likely to actually use, then it probably counts as 'incorrect/misleading'.

This though is barely an API at all - although since you opened the issue perhaps you were trying to use it?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.