Comments

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Issue summary:View changes

update

mikeytown2’s picture

Title:test with other modules» test with other modules & themes
mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

infines’s picture

I'm not seeing any issues with Labjs, Headjs, and Librejs.

mikeytown2’s picture

StatusFileSize
new4.53 KB

Thanks for the report :)

Following patch has been committed.

mikeytown2’s picture

StatusFileSize
new1.98 KB

Following patch has been committed.

mikeytown2’s picture

StatusFileSize
new1.34 KB

Following patch has been committed.

mikeytown2’s picture

StatusFileSize
new6.76 KB

Following patch has been committed.

mikeytown2’s picture

infines’s picture

Nothing to report with scriptjs either.

Just a note: I'm not going to test with jquery update as I've personally never had any success with jquery update, so if someone could tackle that module it would be best.

infines’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

I have advagg working with jquery update. It was one of the first ones I tested.

mikeytown2’s picture

Issue summary:View changes

striking tested modules

infines’s picture

Issue summary:View changes

jquery cross off

mikeytown2’s picture

I just tested LABjs and it's not compatible. The JS that gets loaded is not from AdvAgg.

mikeytown2’s picture

StatusFileSize
new863 bytes

Created this issue for LAB.js and I've committed this patch which will check to make sure the patch has been applied to labjs on the status report page.
#1977122: AdvAgg 7.x-2.x Integration

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Created a Stage File Proxy issue: #1977170: AdvAgg 7.x-2.x Compatibility

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Issue summary:View changes

Unsure about the other modules as labjs was tested as good but I found that it didn't work without patches.

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Component:JS Compression» Code
StatusFileSize
new1.14 KB

Following patch has been committed

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Following patch has been committed

mikeytown2’s picture

Issue summary:View changes

Updated issue summary.

mikeytown2’s picture

Status:Active» Fixed

Marking this issue as fixed. Will field one offs as they come in.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary:View changes

Updated issue summary.

shawnrosspeters’s picture

Any chance of figuring out why Mothership themes do not place nice with AdvAgg?

http://drupal.org/project/mothership - mothership_js_alter()

http://drupal.org/project/mothership - mothership_css_alter()

I've successfully gotten AdvAgg and a Mothership subtheme to play nice, EXCEPT, contextual links are NOT output. The weird part is that the ul for the contextual links is output, but the <a class="contextual-links-trigger" href="#">Configure</a> is not output rendering contextual links virtually useless. I've also checked Chrome inspector and there's no errors of any kind output so I'm at a loss...

The craziest part, and why I want to figure out a way to get this to work, is that with Mothership's options for "Compress all javascripts into one file" and "One css file!" enabled, and AdvAgg enabled the website receives between 97 and 99 score on Google PageSpeed Insights, and the load time on Pingdom is between 800ms and 900ms with less than 20 total http requests.

If the Mothership theme, and AdvAgg could play nice together then we could have some INSANE performance for Drupal all without Boost, Varnish or any other performance boosters. I'd "hate" to see what adding something like Varnish to the mix would do. Maybe a <=500ms load time, and way more potential traffic to be handled? Oh be still my heart.... :-)

shawnrosspeters’s picture

Status:Closed (fixed)» Active

Marking this as Active.

mikeytown2’s picture

I'm pretty sure Mothership's "Compress all javascripts into one file" (mothership_js_onefile) and "One css file" (mothership_css_onefile) are redundant if using AdvAgg's "Combine CSS files by using media queries checkbox". I would also bet that mothership_js_jquery_latest & mothership_js_jquerycdn can be replaced by https://drupal.org/project/jquery_update thus bringing jquery UI up to date as well.

I'll test out the mothership theme some time in the near future.

Depending on how your CSS/JS is added you might see some benefits with advagg_mod's "Optimize CSS/JavaScript Ordering" options. If you have "aggregate" "inline" "aggregate" "inline" these checkboxes should help to group the aggregates together more (to see an example of this, view the source of drupal.org, you will see the inline gaq code in-between js aggregates followed by inline js for drupal.settings).

mikeytown2’s picture

Status:Active» Closed (fixed)

@shawnrosspeters
After doing some testing, that is an issue with mothership not advagg #2061657: Contextual Links not working after upgrade from 2.8 to 2.10

Marking this issue back to closed (fixed)

mikeytown2’s picture

Status:Closed (fixed)» Active

Keeping this here so I can track it.
#2269885: Incompatibility with advagg

shawnrosspeters’s picture

@mikeytown2
It looks like Mothership 7.x-3.x makes overriding Contextual Links CSS & JS optional. There's a new area labeled "Override Contextual Links" with the description:
"Override default contextual links CSS and JS".

I updated the based Mothership theme to version 3 and voila, contextual links return and I can use mothership and AdvAgg together. All is right in the world.

:::UPDATE:::
For those having issues upgrading to 7.x-3.x, you can modify 7.x-2.x to get the contextual links back. What I did was comment out lines 7-14 from "mothership/functions/js.php". Probably not the BEST solution but for a mature project, it works for now. I'll be upgrading my start sub-theme to use Mothership 7.x-3.x but at least I can get Mothership and AdvAgg playing nice.

mikeytown2’s picture

Status:Active» Fixed

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.