Add Message component (error, warning, success). See http://groups.drupal.org/node/283223#Messages

CommentFileSizeAuthor
#1 messages-2.patch17.36 KBLewisNyman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
FileSize
messages-2.patch17.36 KB

What do people think about adding a non-opinionated message style? Seems like a nice default using tints of Drupal Blue.

ry5n’s picture

ry5n CreditAttribution: ry5n commented

I was thinking the same thing. Question is, does Drupal use it now, or are messages always one of the existing three? Wouldn’t mind getting @Bojhan and @yoroy’s takes.

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Status: Active » Needs review
ry5n’s picture

ry5n CreditAttribution: ry5n commented

Looks good. Fixed a few syntax errors in the CSS, committed and pushed to the `messages` branch *and* merged into master. Reverted merge with master at this point, since there are still lots of patches waiting in the wings. This work remains available in the `messages` branch.

ry5n’s picture

ry5n CreditAttribution: ry5n commented
Status: Needs review » Reviewed & tested by the community

Marking this RTBC for the initial rough stage.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented

Just wondering, can you add a screen to review? Not sure what to give feedback on

ry5n’s picture

ry5n CreditAttribution: ry5n commented

@Bojhan I was planning on merging everything into the master branch before asking for review. However, Here’s a link to the current state of the messages branch (scroll to the bottom): http://drupalcode.org/sandbox/ry5n/1932040.git/blob_plain/4015f67e040178...

I’ll go through and post a similar link in the other issues as I mark them RTBC for this initial rough implementation.