Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.it seems ViewsDataCache::set() is never called, so cacheGet() never succeeds and getData() rebuilds the views_data info each time a view is displayed ?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | missing-event-listener-tag-1941164-3.patch | 3.58 KB | Berdir |
| #3 | missing-event-listener-tag-1941164-3-test-only.patch | 2.79 KB | Berdir |
| #3 | missing-event-listener-tag-1941164-3-test-only.patch | 2.79 KB | Berdir |
Comments
Comment #1
yched CreditAttribution: yched commentedtagging
Comment #2
BerdirLooking into this.
Comment #3
BerdirOh man, that's just bad.
Forgot the event listener tag on the kernel destructor. Silly me.
Fixed that and improved the tests to actually terminate the kernel and also add explicit coverage for the path alias whitelist which is just as broken right now. Is there a similar place where we could add a similar assertion for the views data cache?
Comment #4
BerdirAnd now I'm uploading the test-only patch twice. It's getting better and better ;)
Comment #5
yched CreditAttribution: yched commentedOoh. I had no idea we had this pattern of cache classes that wrote on destruct.
Interesting for FieldInfo :-)
Anyway, patch looks good.
Comment #6
yched CreditAttribution: yched commentedComment #7
webchickD'oh. :(
Thanks for the patch, Berdir.
Committed and pushed to 8.x.