Menu translation on node form is broken

This might be related to #1889084: Menu translation tests broken. Please provide enabled modules and their versions.

I think I may have some info to help track this one down...looking at the following code in the i18n_menu.module:

475  * Localize menu item title and description.
    476  *
    477  * This will be invoked always after _menu_item_localize()
    478  *
    479  * Link properties to manage:
    480  * - title, menu router title
    481  * - link_title, menu link title
    482  * - options.attributes.title, menu link description.
    483  * - localized_options.attributes.title,
    484  *
    485  * @see _menu_item_localize()
    486  * @see _menu_link_translate()
    487  */
    488 function _i18n_menu_link_localize(&$link, $langcode = NULL) {
    489   // Only translate title if it has no special callback.
    490   if (empty($link['title callback']) || $link['title callback'] === 't') {
    491     $link['title'] = _i18n_menu_link_title($link, $langcode);
    492   } 
    493   if ($description = _i18n_menu_link_description($link, $langcode)) {
    494     $link['localized_options']['attributes']['title'] = $description;
    495   } 
    496 } 

It looks like $link['title'] is set - which is the menu_router title, but $link['link_title'] is not set. Adding

$link['link_title'] = _i18n_menu_link_title($link, $langcode);

after line 491 seems to fix the issue. I am not really sure this is the correct fix which is why I have not posted a patch to i18n_menu, but I thought I would throw it out to the community to hear some thoughts.

had the very same problem - I changed entity_translation_i18n_menu_node_menu_item_translate in line 267 file entity_trnalsation_i18n_menu.module

from

function entity_translation_i18n_menu_node_menu_item_translate($node, $langcode) {
  // Localization.
  if ($node->menu['language'] == LANGUAGE_NONE) {
    _i18n_menu_link_localize($node->menu, $langcode);
  }
  // Translation sets.
  else {
    $menu = NULL;
    if (!empty($node->menu['i18n_tsid']) && $translation_set = ...

to

function entity_translation_i18n_menu_node_menu_item_translate($node, $langcode) {
  // Localization.
  if ($node->menu['language'] == LANGUAGE_NONE) {
    $node->menu['link_title'] = $node->menu['title'];
    _i18n_menu_link_localize($node->menu, $langcode);
  }
  // Translation sets.
  else {
    $menu = NULL;
    if (!empty($node->menu['i18n_tsid']) && $translation_set = ...

hope this will get fixed soon as it's a major thing to have string translated menu (I did never see the point in having extra menu items for every language -> retro style like having a node for each language instead of ET-ing it).

greets,

attisan

Hello

Attaching a patch that fixes this issue based on attisan's approach. This patch is tested against the environment detailed below:

• Drupal 7.22
• i18n 7.x-1.8
• ET 7.x-1.x-dev / 7.x-1.0-beta2

Regards!

Thanks for the patch. I think this is the correct approach.

I added support for the link description, and fixed an issue with translation sets ("separate menu items"); I think this should make the ET menu tests pass again. Let's see what the bot says :)

Bot is green, so I went ahead and committed #6. :)

Cool, thanks!

awesome!

hello,
I'd highly appreciate if someone could help me out. I've trying to add this patch http://drupal.org/node/1941080#comment-7293146 to my project, in the specific place it should and it always fails. I am assuming it is the patch because I tried with others and worked perfectly. I'm using NetBeans 7.0 to add patches to my project. Currently working with Drupal 7.22.
Any suggestions?
Thanks in advance.

The patch has been committed already, so just use the development version and you should be fine. If something still isn't working correctly, please create a new issue following the bugfixing guidelines outlined on the project page.

I had this exact issue with the latest version of Drupal and with the latest stable versions of i18n and entity_translation. After reading this bug report I tried to update to the dev version of i18n and entity_translation with no luck, this bug is still present. I had to disable the entity translation menu for the moment.

So, I had the latest stable release, and there is the bug.

I went to dev and the bug is still present.

If the patch is actually included in latest dev, it doesn't work.

Let me clarify:
I have the main menu translated with entity translation menu. That creates duplicate entries in admin/structure/menu/manage/main-menu for each language the menu link is translated into.
The module works ok everywhere (only showing the menu links of the chosen language) except for all these pages: node/xxx/edit

When you are editing a node (every node, translatable and untranslatable ones) all the menu links translations are shown, i.e. every menu link is shown twice if you have 2 enabled languages.

The bug is independent on how you added the menu link, being it a custom one, from views, from panels etc.

The workaround for me was to delete the translated menu links and translate them with i18n_strings.
The setting in the menu is "Translate and localize".

So, can anyone remind me what is Entity translation menu for?
Is it useful only if we don't use string translation on the whole site (which will never be the case in Drupal 7)??

Or was it me misunderstanding how this module should be used (i.e. only with Menu setting "Fixed Language. Menu items will have a global language and they will only show up for pages in that language.")??

Thanks

I did update both i18n and entity_translation to latest dev, and like @kopeboy, I had no luck making this work. This is unfortunate, since in real life, people do want to use menu items, and without them it almost makes the whole entity_translation module useless.

Hello, thank you for your work on this module.
I agree with above that this patch doesn't work with the latest dev version 7.x-1.0-beta3+14-dev.
In my case - just one language version - this "Menu translation: Menu link enabled only for the .. language" didn't worked as expected. Once I checked this I was not able to uncheck it again.
I believe that problem is in the $tset variable in the entity_translation_i18n_menu.module. It expect values 0 or 1, but in my case the right option is LANGUAGE_NONE ( = und).
I put this on line 55 and my issues seems to be solved.
if (!$tset) {
$node->menu['language'] = LANGUAGE_NONE;
}

As far as I understand it, this is the same issue as the same I'm adding as related? I have this a lot of thought, and perhaps the proposed solution in #2724111 could be a viable option.