Product and price submodules doesn't need to depend on rules.module [#1940794]

I'm leveraging commerce_product and commerce_price and just saw that rules.module wants to be on board with no invitation!

Comment	File	Size	Author
#1	commerce-product_price_no_rules.patch	1.27 KB	jonhattan
#1
	commerce-product_no_rules.patch	900 bytes	jonhattan

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jonhattan

Spanish

Plasencia

CreditAttribution: jonhattan commented 12 March 2013 at 15:56

Title:	commerce_product doesn't need to depend on rules.module	» Product and price submodules doesn't need to depend on rules.module
Component:	Product	» Other

File	Size
commerce-product_price_no_rules.patch	1.27 KB

I don't think price needs to depend on rules neither.

Comment #2

JulienD CreditAttribution: JulienD commented 29 March 2013 at 13:28

Hi,

That certainly because Rules is needed by the commented code at the bottom of the commerce_product.test file. Rszrama decided to comment this big chunk of code in order to rewrite it and maybe we should do the same with the Rules dependency.

For the price module I think this dependency is useful.

Comment #3

rszrama CreditAttribution: rszrama commented 23 July 2013 at 18:59

Status:

Needs review

» Fixed

The original patch satisfies the needs of the tests by making the test helper module depend on Rules, so no worries there. Re: JulienD's concerns, the primary use cases involving the Price module will involve Rules, but technically speaking there's no reason to force the dependency since we never directly invoke the API. We just passively expose Rules integration points in the event that Rules is present on a site.

Committed.