• Save.
  • Create Menu.
  • Edit menu.
  • Create menu item.

Only the adding of actions to the contextual toolbar!

Comments

iSoLate’s picture

Status: Active » Needs review

tests will be written on the proof of concept in the paddle_contextual_toolbar module.

iSoLate’s picture

Assigned: iSoLate » Unassigned
Cyberwolf’s picture

Status: Needs review » Needs work

I'd rephrase the following documentation a bit:

Callback of the after_build of the paddle_menu_manager_menu_overview_form

In core they use the pattern: "After-build function ..." or "#after_build callback for ...".

Furthermore needs some modifications for the pending icon changes in paddle contextual toolbar.

iSoLate’s picture

Assigned: Unassigned » Cyberwolf
Status: Needs work » Needs review

Fixed!

Cyberwolf’s picture

Assigned: Cyberwolf » Unassigned

I fixed one small issue and changed the create & edit menu actions to use the new forms which finally made it into 7.x-1.x this evening.

e4800f847f33f628d144b62c68d426036485ca26 Use new menu create/edit form.
95dc472af3d5d37a1e943da9520361853c13b876 Fixed PHP undefined index error when there are no menu items yet in a menu and thus the button is also missing.

These 2 commits need a quick review and then I believe this one is RTBC!

iSoLate’s picture

Status: Needs review » Fixed

Reviewed and merged!

pfrenssen’s picture

Status: Fixed » Needs work

This has been put in the wrong file. The form builder is in paddle_menu_manager.admin.inc, so it would make sense to put the #after_build callback in the same file.

Cyberwolf’s picture

Status: Needs work » Fixed

Can you make a follow-up issue for that pfrenssen? This is just a very minor modification and not a real blocker for this issue. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.