_locale_export_po_generate must not create empty msgid and they mustn't contain "\r" [#1940436]

In includes/locale.inc, _locale_export_po_generate outputs the following:
_locale_export_string($string['source']); as a value for msgid without testing the string is non-empty.
But there should be only one empty msgid in a po file: inside its header.
msguniq from gettext will abort on a duplicate empty msgid and such a po file will be unusable until you manually remove the duplicated empty msgid.

Other than that, msgid should not contains "\r" escape-sequence (msg* utils will throw a warning on them).

Comments

Comment #1

drzraf CreditAttribution: drzraf commented 13 March 2013 at 09:04

http://git.savannah.gnu.org/cgit/gettext.git/tree/gettext-tools/doc/gett...

An empty string is reserved to contain the header
entry with the meta information Header Entry. This header
entry should be the first entry of the file. The empty
string is reserved for this purpose and must not be used anywhere else.

Comment #2

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 20 March 2013 at 14:07

How do those source strings end up in your database? For example t() ensures NOT to save an empty string under any circumstance to the db (and potx module which is used as a backend for localize.drupal.org will not extract empty strings either and flag those as warnings). I'd look at how do those get into the database in the first place.