Ran into a problem in #1898054: comment.module - Convert PHPTemplate templates to Twig where the testbot was failing because Bartik didn't have it's templates converted to twig files - see comment 4.

This alerted me to the fact that tests against themeable elements that Bartik is overriding are being run against Bartik, not against core.

Since essentially zero themes are using Bartik as a base theme, we really want our tests to be run against the core template files. It would be very easy for somebody to make a bad change to a core template file, forget to update Bartik to reflect the change and see tests passing that should actually fail.

Comments

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Status: Active » Closed (duplicate)

Great catch, it looks like this will be taken care in this issue: #1595028: Convert tests using Standard profile to use Testing profile instead

+++ b/core/modules/comment/lib/Drupal/comment/Tests/CommentPreviewTest.phpundefined
@@ -14,13 +14,6 @@
 class CommentPreviewTest extends CommentTestBase {
 
-  /**
-   * Use the standard profile.
-   *
-   * @var string
-   */
-  protected $profile = 'standard';
-