Remove taxonomy_overview_terms() and taxonomy_overview_vocabularies() theme functions in favour of table #type

Nice cleanup!
Vocabularies should be replaced with own controller #1891690: Use EntityListController for vocabularies but the issue waiting for #1855402: Add generic weighting (tabledrag) support for config entities (DraggableListController)

165 insertions, 217 deletions... I like the look of this

Assigning to @xjm as taxonomy module maintainer for a review...

Sorry got a really minor minor nit...

+++ b/core/modules/taxonomy/taxonomy.admin.incundefined
@@ -238,56 +213,96 @@ function taxonomy_overview_terms($form, &$form_state, Vocabulary $vocabulary) {
+      // Verify this is a term for the current page and set at the current ¶
+      // depth.

Space at end of line...

#3: 1938912-3-language-tables.patch queued for re-testing.

Needs @xjm confirm for commit :)

#7: 1938932-7-taxonomy-table.patch queued for re-testing.

Talked to @xjm in IRC and she have no idea why this one assigned.
This one about conversion #theme functions and does not touch taxonomy

But there's another task waiting that patch #1891690: Use EntityListController for vocabularies

I think better to commit this one and finish taxonomy CMI conversion

I went to review this, but it needed to be rerolled. xjm indicated that she doesn't have time soon to review this, unassigning.

Actually it's more that I have maybe one-tenth of one clue about the render/theme layer. ;) All I'd do is test the patch manually, so if someone else can do that, this is a go.

@timlunket thanx a lot for re-roll.

Proper merge

Well, if my patch passed and was wrong like that, we're missing test coverage.

Re-title to point a scope

@tim.plunkett There's 3 reasons to not write tests here
1) This code should be dropped in favour of list controllers #1891690: Use EntityListController for vocabularies & a bunch of forum issues
2) Scope of this issue to drop useless theme functions and convert the render
3) Making test that some link have no query string leads to disability to extend it

I can't RTBC it as my patch last but let's get this in and unfreeze conversion of taxonomy and forum

Forget to attach interdiff - taxonomy-1938932-14-broken_withtest.txt
WebTestBase::assertLinkByHref() makes check as contains to no ability and reason to check query-string

taxonomy-1938932-12.patch actually to commit

#type table itself does not have tests yet either - see #1948374-8: #type 'table' allow attributes on table cells.

Notwithstanding that we do need expanded table rendering tests based on Drupal\system\Tests\Theme\TableTest to include the #type table consolidations' support for tableselect/tabledrag, this patch is implementing existing #type table functionality (just like #1938904: Convert filter theme tables to table #type), so I have created #1975152: Expand render test coverage for #type table and consider #17 RTBC.

This is great clean-up!

Committed and pushed to 8.x. Thanks!

Btw, I don't like committing this without test coverage, but there's a precedent for doing so with the column stuff.

Therefore, I escalated #1975152: Expand render test coverage for #type table to major.