Problem/Motivation

The Drupal\Core\DependencyInjection\ContainerBuilder class can be simplified now that Drupal is using Symfony 2.2.0.

Proposed resolution

The patch removes the obsolete code.

CommentFileSizeAuthor
#11 container-builder-simplification-11.patch6.35 KBfabpot
#5 container-builder-simplification.patch4.52 KBfabpot
container-builder-simplification.patch3.32 KBfabpot
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fabpot’s picture

fabpot CreditAttribution: fabpot commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, container-builder-simplification.patch, failed testing.

fabpot’s picture

fabpot CreditAttribution: fabpot commented
Status: Needs work » Needs review

container-builder-simplification.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, container-builder-simplification.patch, failed testing.

fabpot’s picture

fabpot CreditAttribution: fabpot commented
FileSize
container-builder-simplification.patch4.52 KB
fabpot’s picture

fabpot CreditAttribution: fabpot commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, container-builder-simplification.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

When I use the simplytest.me button the installation works but when I click on the "go to my site" button I get a white page. After refreshing the site is up and running.

Maybe that is causing these failures.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

After refreshing the site is up and running.

Oh, possibly important detail. Potentially means that

A) the container fails to compile upon first attempt.

B) an already compiled + dumped container fails to reload/initialize.

+++ b/core/lib/Drupal/Core/DrupalKernel.php
@@ -314,18 +314,25 @@ protected function initializeContainer() {
+    // Compilation must be called after synthetic services are set
+    if ($needsCompilation) {
+      $this->container->compile();
+    }

Hm. I thought the idea of the upstream patches was to allow Container::set() to work even on a frozen container?

(This might circle back into B) above.)

fabpot’s picture

fabpot CreditAttribution: fabpot commented

Ok, I've just found why it does not work. That's tough. Actually, there are many problems with the current implementation. I will provide a patch for these issues soon.

fabpot’s picture

fabpot CreditAttribution: fabpot commented
Status: Needs work » Needs review
FileSize
container-builder-simplification-11.patch6.35 KB

Let's see if I got this right.

Status: Needs review » Needs work

The last submitted patch, container-builder-simplification-11.patch, failed testing.

fabpot’s picture

fabpot CreditAttribution: fabpot commented
Status: Needs work » Needs review

#11: container-builder-simplification-11.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, container-builder-simplification-11.patch, failed testing.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Assigned: fabpot » Unassigned
Issue summary: View changes

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs work » Closed (outdated)

This all seems obsolete, we are two major versions of Symfony ahead now and nothing in the patch is relevant any more.