Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Comment | File | Size | Author |
---|---|---|---|
#10 | 1937944-forminterface-simpletest-drupal-10.patch | 11.54 KB | ACF |
#7 | 1937944-forminterface-simpletest-drupal-7.patch | 11.53 KB | ACF |
#7 | interdiff.txt | 1.58 KB | ACF |
#5 | 1937944-forminterface-simpletest-drupal-5.patch | 11.48 KB | ACF |
#3 | 1937944-forminterface-simpletest-drupal-3.patch | 12.85 KB | ACF |
Comments
Comment #1
ACF CreditAttribution: ACF commentedComment #2
ACF CreditAttribution: ACF commentedFixing indentation.
Comment #3
ACF CreditAttribution: ACF commentedUpdate to use form controller in router.
Comment #4
amateescu CreditAttribution: amateescu commentedThis is already handled in SystemConfigFormBase.
Comment #5
ACF CreditAttribution: ACF commentedThanks for the review, another attempt.
Comment #6
amateescu CreditAttribution: amateescu commentedThanks, much better now! Just a couple more things to fix:
Wrong indentation here.
Needs to use $this->configFactory.
Comment #7
ACF CreditAttribution: ACF commentedMade those changes.
Comment #8
ACF CreditAttribution: ACF commentedComment #9
Crell CreditAttribution: Crell commentedThis should now be 'route' => 'simpletest_settings', with no page callback.
Comment #10
ACF CreditAttribution: ACF commentedUpdated with the change.
Comment #11
Crell CreditAttribution: Crell commentedHuzzah!
Comment #12
webchickCommitted and pushed to 8.x. Thanks!