When I click Edit on Default recipe book, it brings up a blank recipe book, not the existing one. If I create a new book, I still can't edit it. Has anyone else seen this. I have another version working and it's not causing any issues there, and functions fine, so I'm trying to track down the differences between the two sites, but haven't found any yet. Any ideas?

CommentFileSizeAuthor
#9 botcha-fix_admin_form_actions-1937690-9.patch2.96 KBoadaeh
#7 botcha-fix-ability-to-edit-recipebook-1937690-7.patch818 byteserikhopp
#5 botcha_edit_recipebook.patch934 byteserikhopp
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jbiechele’s picture

jbiechele CreditAttribution: jbiechele commented

I have the same issue here with the version 7.x-3.x-dev from 2013-Apr-07.
Will this be fixed soon?

webermann’s picture

webermann CreditAttribution: webermann commented
Issue summary: View changes

I have the same issue too. I use the Version 7.x-3.3 and can't edit and delete the entries in the recipe book. Only new entries work.

erikhopp’s picture

erikhopp CreditAttribution: erikhopp commented

I was also seeing this issue. Then I noticed that I could edit the recipe books on my staging site (where I first installed the module), but not on my live site. Uninstalling and reinstalling the botcha module on my live site seemed to fix the issue as I can now edit the recipe books on the live site. It seems that there is, perhaps, some setting not being carried over within Features / Strongarm or perhaps I enabled MOOAPI and Botcha at the same time and Botcha didn't like that (Perhaps MOOAPI has to be enabled first).

I hope this helps.

Erik

erikhopp’s picture

erikhopp CreditAttribution: erikhopp commented

Hmmm. Well that is strange. Now the issue is back. I cleared caches and hard reloaded the configuration pages because I was seeing "Theme hook botcha_forms_form_botcha_forms not found." errors in the dblog. That seemed to clear up the errors, but now clicking edit on the recipe book, brings me to the add form again, instead of the edit form.

erikhopp’s picture

erikhopp CreditAttribution: erikhopp commented
Status: Active » Needs review
FileSize
botcha_edit_recipebook.patch934 bytes

Ok, I'm not entirely sure of all of the implications of this patch, but it is simple and it seems to fix the issue.

Please review.

Status: Needs review » Needs work

The last submitted patch, 5: botcha_edit_recipebook.patch, failed testing.

erikhopp’s picture

erikhopp CreditAttribution: erikhopp commented
FileSize
botcha-fix-ability-to-edit-recipebook-1937690-7.patch818 bytes

Here is another attempt at producing a patch that passes.

erikhopp’s picture

erikhopp CreditAttribution: erikhopp commented
Status: Needs work » Needs review

Marking as 'needs review' again.

oadaeh’s picture

oadaeh CreditAttribution: oadaeh at Hook 42 commented
Version: 7.x-3.2 » 7.x-3.x-dev
FileSize
botcha-fix_admin_form_actions-1937690-9.patch2.96 KB

The patch in #7 does fix the problem outlined here, but there are other actions in that same function that also do not work:

  • Deleting a form
  • Editing a form
  • Deleting a recipe book

Also, in addition to those, the submit handler for deleting recipe books is not correct.
The attached patch addresses the original problem and the additional 4 listed in this comment.

Status: Needs review » Needs work

The last submitted patch, 9: botcha-fix_admin_form_actions-1937690-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

oadaeh’s picture

oadaeh CreditAttribution: oadaeh at Hook 42 commented

I believe those test failures are related to #1988550: config menu and page disappear intermittently.. The test failures are unrelated to the code changes in this ticket, but might be because the patch in the other ticket was not applied.