Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Very nice to see that the Location information can now be provided within the feed items!
Currently the module can only pull the Location from Text and Node Reference fields. As many use cases will implement an Addressfield within a node, it would be nice to be able to use it for the Location information of the iCal feed items.
Markus
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | date_ical-addressfield-support-1937224-6.patch | 1.79 KB | vlad.pavlovic |
| #4 | date_ical-addressfield-support-1937224-4.patch | 1.79 KB | vlad.pavlovic |
Comments
Comment #1
coredumperror CreditAttribution: coredumperror commentedHmmm, I'm not experienced with this kind of thing, but adding even more code to support even more contrib modules seems like it might not be the appropriate method. I could be totally wrong, though. Does anyone have experience with integrating several contrib modules' features together?
Comment #2
coredumperror CreditAttribution: coredumperror commentedI'm an idiot. Of course Date iCal should support this. I can't promise that it'll happen soon, though.
Comment #3
vlad.pavlovic CreditAttribution: vlad.pavlovic commentedRobert, would you like for me to take care of it?
Comment #4
vlad.pavlovic CreditAttribution: vlad.pavlovic commentedAttached is a patch that will add addressfield support. I have explicitly removed 'first_name' and 'last_name' from the Addressfield output for LOCATION.
Let me know if there are any issues and if not, I can push to dev.
Comment #5
coredumperror CreditAttribution: coredumperror commentedThanks for this, vlad. I've been on vacation for the last two weeks, so I hadn't had time to even think about this.
Comment #6
vlad.pavlovic CreditAttribution: vlad.pavlovic commentedPatch has be re-rolled to include previous fixes for other issues.
I have pushed it to dev.
Comment #7
vlad.pavlovic CreditAttribution: vlad.pavlovic commentedMeant to mark fixed, not close it.