Use TSID for menu calling

#1934808: Overview of menu items in menu has landed!

I'll start reviewing this.

admin/structure/menu_manager still shows all menus, I think it should only display the menu's which have a translation set.

$menu = db_select('menu_custom', 'cm')
    ->fields('cm')
    ->condition('i18n_tsid', $tsid, '=')
    ->condition('language', $language_content->language)
    ->execute()
    ->fetch(PDO::FETCH_ASSOC);

Inside paddle_menu_manager_menu_overview_form() I'd rather use the i18n translation API methods, like i18n_translation_set_load()) instead of using straight queries on the database.

$this->drupalGet('admin/structure/menu_manager/' . check_plain($menu['i18n_tsid']));

The tsid is always numeric AFAIK, thus it shouldn't be escaped with check_plain().

Assigning for review.

The code looks very good, but I have some small remarks about the tests:

Duplicated code

3 of the tests in PaddleMenuManagerUITest start by creating one or more menus. This can be moved to the setUp() method.

Missing documentation

There is a call to menu_rebuild() in PaddleMenuManagerUITest::testMenuOverview(). This is needed because we are creating menus directly through the API rather than using the menu creation forms. It is rather scary to see this in a test though, so some documentation would be nice.

Addressed the issues from #10, and did some more refactoring and cleanup.

0987992 Added documentation.
0af8991 Refactored PaddleMenuManagerUITest: Store translation set ids in a protected variable.
97d1065 Refactored PaddleMenuManagerUITest: Store menus in a protected variable.
5cf6d60 Refactored PaddleMenuManagerUITest: Store language codes in a protected variable.
bc0c92a Inline array declarations are super clean.

One more small change: use one of the menus created in the setUp() method in testMenuOverviewTypes():

b505050 Reuse one of the menus created in the test setUp().