I found a function call in ViewsBundle. This definitely needs a comment.

bundle_is_constant.patch1.25 KBchx
PASSED: [[SimpleTest]]: [MySQL] 52,487 pass(es). View


jhodgdon’s picture

It looks like getPluginTypes() is already a static function... So are these comments really necessary?

msonnabaum’s picture

Status: Needs review » Needs work

If there's something not implied about this code by the fact that it's static, these comments do not clarify it for me.

andypost’s picture

Maybe better to say that we always have constant set of plugin types used by views?

@chx Having this comment makes more questions and have no answer

chx’s picture

Assigned: chx » Unassigned
Issue summary: View changes

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.