Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Inline is very useful module. Updating HEAD for Drupal 6x beta
will be very appreciated.
Comment | File | Size | Author |
---|---|---|---|
#17 | inline.d6-port.patch | 9.85 KB | sun |
#14 | inline.d6-port.patch | 10.12 KB | sun |
#11 | inline.patch | 9.36 KB | eaton |
#6 | drupal-6--1.patch | 13.06 KB | eaton |
#3 | inline.theme_.inc_.gz | 551 bytes | SiliconMind |
Comments
Comment #1
sunAgreed. Who wants to take up the ball?
Comment #2
sunThis task depends on Inline API to be ready.
Comment #3
SiliconMind CreditAttribution: SiliconMind commentedHere is quick (and dirty) patch for inline-5.x-1.1 to make it work with drupal 6.x
add new file inline.theme.inc and apply attached patch.
you'll also need ImageCache patched for drupal 6.x, so check this thread: http://drupal.org/node/232624
Comment #4
eaton CreditAttribution: eaton commentedHere's a version of the patch that removes the notices, and includes the theme.inc file without requiring a separate download.
Comment #5
eaton CreditAttribution: eaton commentedHmmmm. On the other hand, attaching the patch file doesn't seem to work. Oh, well.
Comment #6
eaton CreditAttribution: eaton commentedThat's more like it.
Comment #7
sun- AFAIK, menu item descriptions should not be t()'d
- Why is that change?
- This also looks like a logical change to me - why?
- CVS Id tag is missing on first line in inline.theme.inc
Other than that, the patch looks good. However, it would be nice if those coding-style changes could be avoided (leaving code clean-up to another patch against both D5 and D6 afterwards).
Comment #8
eaton CreditAttribution: eaton commentedBoth of the changes you noted were causing notices to be thrown when nodes were loaded -- uninitialized variables being referenced, etc. Apologies for the whitespace -- my editor was set to automatically strip trailing spaces and that showed up in the patch without my realizing it. I'll roll a new version without that. :)
Comment #9
sunLet's deal with all coding style and E^ALL fixes in #273489: Code clean-up, thus limiting this patch to required changes for D6 only.
Comment #10
sun#282173: Drupal 6 port has been marked as duplicate of this issue; contains a patch, too.
Comment #11
eaton CreditAttribution: eaton commentedRe-rolled version of the patch without the E_ALL fixes or whitespace corrections. Hopefully it will be committed at some point.
Comment #12
sunWell, I think we're close...
- Menu item description still contains t().
- inline.theme.inc misses a CVS Id comment on second line of the file.
Also, when trying to apply this patch:
Comment #13
eaton CreditAttribution: eaton commentedJust an FYI that I'll be using the earlier version with the E_ALL fixes on my own blog; others are welcome to continue the porting work.
Comment #14
sunah, well... it seems that all of you are working with an extremely out-dated version of Inline (> 1 year). That explains, why all posted patches do not apply at all.
Please test attached patch - which should apply cleanly against the latest development snapshot.
Comment #15
koorneef CreditAttribution: koorneef commentedTried the patch on: inline-5.x-1.x-dev.tar.gz
Patch applied except for the .info file, manually editted this file.
Could enable the module, but when trying to administer module got a PHP error:
Failed opening required 'sites/all/modules/inline/system.admin.inc'
Inline shows up in inputfilter admin pages.
No further testing done.
Comment #16
sunHm. I do not think that this error is related to Inline module and this patch, because there is no reference to system.admin.inc in this patch.
Comment #17
sunCommitted attached patch.
Comment #18
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.