Create configuration schemas for Tour module

Are tips not plugin based? That is what I've seen in a quick look. That would necessitate some dynamic type definitions to support contrib tour plugins to expose other textual items, no?

Labels aren't used at present but will be in contrib - see #1921188: Implement Tour UI module

Thanks @larowlan I have checked the latest patch attached to the issue and all labels matching except Data Class and Data ID. However, they are sequence so we can not update them. so label wise latest patch looks good to me.

#1: 1935094-tour-schema-cmi-1.patch queued for re-testing.

@larowlan: can you look at whether the schema fits the system otherwise? Also how would this work with tip plugins? To me the schema look good, although I don't see why it would fail anything. Sent for restest for this. I only found this issue:

+++ b/core/modules/tour/config/schema/tour.schema.ymlundefined
@@ -0,0 +1,56 @@
+
+
+# Tour tip with associated fields.
+
+tour_tip:
+  type: mapping
+  label: 'Tour tip'

Superfluous comment? The name and the label seems to tell it all.

I have made the change outlined in #10.

Woops. Here we go. Added a interdiff for good measure.

#13: 1935094-tour-schema-cmi-13.patch queued for re-testing.

Schema looks good to me, however this still stands and needs feedback:

@larowlan: can you look at whether the schema fits the system otherwise? Also how would this work with tip plugins?

I don't believe the fails.

Fix currently included with #1948884: Create configuration schemas for block and custom_block modules, waiting for commit there.

That one got committed. Can someone please respond to my question on plugins? (If we want to see this committed :).

#13: 1935094-tour-schema-cmi-13.patch queued for re-testing.

Hi Gabor
Yeah tips are plugin based.
There is text plugin in core now, image plugin (takes a url) in the tests.
There is also a multi page plugin that has three fields (title, body, url) with url for 'next page'.
So yeah - these are plugin based and contrib could add anything that implements the tip interface.
Sorry about the delay
Lee

Ok, so that means the existing proposed schema does not work since it does not have any provisions for dynamic typing (AKA plugins to be explained). In the schema tour_tip is one fixed type, no possibilities for plugins. Sounds like we need to make the type dynamic based on the plugin value in the tip data. See http://drupal.org/node/1905070#dynamic-types

Add on D8MI sprint for closer tracking.

Sounds like the multipage plugin is in core and would need coverage too?

As discussed in IRC.

Thanks Gabor and vijaycs85

The multipage side of things is in the following issue: http://drupal.org/node/1942576

I don't believe this will result in a brand new tip type.

I believe we should be able to define a tour.tip type that defines the base properties and extend it with the two other types with more properties, right? :) That would let us centralize the base properties that both tip types extend from. Makes it easier to pin-point differences and maintain the schemas.

Also the image plugin is with the tests, not in the main module, so it should be defined in a schema under the test module not in the main module.

My only remaining remark is the tour URI in the image schema would be "Image URL" right? Instead of just URL which is less descriptive. Otherwise looks all good to me :)

Looks all good to me, it supports plugins now and optimises schema definition for them :)

Committed and pushed to 8.x. Thanks!

Superb, thanks!