Use override free configuration context for SystemConfigFormBase

That's pretty cool

+++ b/core/modules/views/views_ui/lib/Drupal/views_ui/Form/SettingsFormBase.phpundefined
@@ -29,10 +29,20 @@
+    config_context_enter('config.context.free');

So all other places in core activate the context on the form and on the submit function, why aren't we doing the same in the SystemConfigFormBase ?

Ups.

Oh nice! I'm wondering whether this should be tested? For example by just checking the value of the value on the object.

This is great. It really makes it easier for implementors.

This looks like useful information indeed for all settings forms to have.

Committed and pushed to 8.x. Thanks!

Woot :) Retroactively tagging for config language.

You've globally force-disabled any kind of context for any kind of configuration/settings form here.

This means that all code is unilaterally enforcing no context for all of these forms.

Even if you instantiate these forms for a specific context, the forms will reset the context to nothing.

Context-specific handlers are not able to skip or override that decision, since you applied it to the very base class for all configuration forms. PHP does not support mixins. Thus, the context can only be revert-reverted on a form-specific basis, by overriding the form class being used at appropriate layers, individually, for each specific form.

Is that really what you intended to do?

You're only locked into that context if you use the create() method that is provided for your convenience. You'll notice that the constructor only dictates that it needs *a* context, not *which* context.