Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
the module is way cool, only thing missing [for me] is a way to limit it's functionality to certain pages [via context or any other way]
Comment | File | Size | Author |
---|---|---|---|
#28 | View_on_pages_context_support-1929888-28.patch | 5.7 KB | dqd |
#15 | page_control-1929888-15.patch | 5.16 KB | Deciphered |
Comments
Comment #1
RobLoachWould be a great idea... Context support would be nice. Was also thinking having a image field formatter for Vegas so that you could create a View of select image fields and than display those in a block on the page, and have contextual backgrounds appear.
Comment #2
otorrents CreditAttribution: otorrents commentedI would find very practical to be able to select what themes or pages this module apply.
Comment #3
Patrick Nelson CreditAttribution: Patrick Nelson commentedI agree, being able to choose by page, or context would be excellent. It is possible to "override" using CSS but the backgrounds are still loading behind the page so it's not ideal.
Comment #4
deixadilson CreditAttribution: deixadilson commentedI think it is a mandatory feature for this module. And maybe you could specify the classes or ids of the wrappers for the plugin to be loaded into.
Comment #5
Vacilando CreditAttribution: Vacilando commentedMuch needed functionality indeed. For the beginning it could be as simple as a textarea where we could type paths to be included or excluded (like what the core Block module has).
Comment #6
zmove CreditAttribution: zmove commented+1 for this, this woule be really useful.
Comment #7
admdh CreditAttribution: admdh commentedi found i way how not use it on front page.
So in modules folder the is vegas.js
i have added "not-front" class to body on 13th line
so code looks now like this
Drupal.behaviors.vegas = {
attach: function (context, settings) {
$('body.not-front').once('vegas', function() {
and background does not appears on front page now..
Comment #8
Anonymous (not verified) CreditAttribution: Anonymous commentedThis seems like a show stopper for me. I only want vegas on the landing page, not every page on the site.
Comment #9
Anonymous (not verified) CreditAttribution: Anonymous commentedJust an FYI, if some simply is not an option, rules integration is probably preferable over context.
Comment #10
Anonymous (not verified) CreditAttribution: Anonymous commentedLooks like the Supersized module offers this functionality with context integration.
Comment #11
Anonymous (not verified) CreditAttribution: Anonymous commentedI found that supersized had its own issues. I could not get the context option to work for that module. I am using the backstretch module for now but I would prefer Vegas if there was just some way to limit the pages on which it appears.
Comment #12
Neil McKay CreditAttribution: Neil McKay commentedRegarding #7 above, I found that I was able to get the slideshow to show ONLY on the front page by changing line 13 to
$('body.front').once('vegas', function() {
That makes me very happy.
Comment #13
Anonymous (not verified) CreditAttribution: Anonymous commentedThanks for sharing Neil McKay!
Comment #14
Neil McKay CreditAttribution: Neil McKay commentedI realized that I can create a content type specifically to contain the slideshow
and then modify line 13 of the vegas.js (see #7 & 12 above) to say
$('body.node-type-my_content_type').once('vegas', function() {
(where my_content_type is the machine name of the content type I created)
That way I can have the slideshow display on only one interior page if I want. The content type could be a clone of my regular content type if I wanted, with the only exception being the name and machine_name. putting that machine name in line 13 will make ONLY a page in that content type display the slideshow.
Now my question is, would it be bad form to clone the Vegas module under a different name so as to have different slideshows show on different content types? Or is there a more elegant way to do that?
Comment #15
Deciphered CreditAttribution: Deciphered commentedAdded a basic page control system based directly off the Block module page control system.
I also added a new hook, hook_vegas_enable(), which any module can implement to return TRUE or FALSE, however if any module returns TRUE then the Vegas module will be active. A simple Context plugin could be created, but I don't currently have that need as what I've implemented suits my personal needs, and can be used in Context via the Contextual Variables module (https://drupal.org/project/context_variable).
Comment #16
Vacilando CreditAttribution: Vacilando commentedTested and using in production; works excellent!
Comment #17
jrochate CreditAttribution: jrochate commentedI'm also using in production.
Thanks.
Comment #18
Deciphered CreditAttribution: Deciphered commented(If you've reviewed and tested the patch, please consider marking it as RTBC (Reviewed and Tested By the Community / Ready To Be Committed) to increase the chance of this being committed.
Comment #19
Manuel P.V. CreditAttribution: Manuel P.V. commented#18 How is marked as RTBC?
Comment #20
Deciphered CreditAttribution: Deciphered commented@Manuel
When commenting on this issue, there's the 'Issue metadata' section above the Comment section, simply adjust the 'Status' from 'Needs review' to 'Reviewed & Tested by the community'.
Comment #21
demonrage CreditAttribution: demonrage commentedworks like a charm, really cool.
Comment #22
robriley78 CreditAttribution: robriley78 commentedPatch worked great for me. Thanks.
Comment #23
kingfisher64 CreditAttribution: kingfisher64 commentedYep works lovely.
@RobLoach would you please be so kind as to commit this as it's a big usability improvement :)
Thanks
Comment #24
pringlz CreditAttribution: pringlz as a volunteer commentedPatch works great! Maybe somebody add features to alpha?
Comment #25
dqdHoly cow! ... this is an old one. Especially because of the fact that this is a main reason to favour a module over a theme implementation, as I have stated already on another spot. Thanks to all the reports and thanks to @Deciphered for the patch. Since I am a new co-maintainer of this project I will commit this patch to dev immediately.
Comment #26
dqdLet me reroll this against latest dev ...
Comment #27
dqdComment #28
dqdrerolled patch via patch -p1 ...
... please review
Comment #29
jbitdrop CreditAttribution: jbitdrop as a volunteer and at MAROQQO studios commentedpatch applies cleanly on latest 7.x-dev - functionality is visible and works without flaws here. tested by setting visible on
<front>
only.Comment #30
dqdwow that was fast! :) ... thanks for report, @jbitdrop - same here. And since it has been tested before already and only needed another reroll against latest dev,we maybe should commit it to make the community happy. ;)
Comment #32
dqdComment #33
dqdComment #34
dqdNew 7.x beta release published. Feature added.
Comment #35
dqdComment #36
jbitdrop CreditAttribution: jbitdrop as a volunteer and at MAROQQO studios commentedWow! Thanks @diqidoq! You were really fighting the issue queue last night.
diqidoq++
Comment #37
dqdAnd the feature is already ported to Drupal 8 (I think it was coming in by the github code of @medienverbinder which I used as basis for the 8.x dev branch init, kudos!) So let's set it to 8.x to have it on radar for the D8 port beta blocker list and if any new flaws are chiming in.