Problem/Motivation

When adding the Find Replace plugin, a typo in the description of "Match whole word/phrase" in the "configure" text contradicts itself and makes it unclear what the effect of selecting the "Match whole word/phrase" checkbox will be:
If checked, then the whole word or phrase will be matched, e.g. "book" will match not match "book" in "the book".

Steps to reproduce:

  1. Go to admin/structure/feeds/tamper/list/[name-of-your-feed].
  2. Click the 'Add plugin' link below a mapping.
  3. Click the 'The plugin to add' dropdown.
  4. Select 'Find replace' (in the 'Text' category).
  5. Scroll down if necessary and read the description for the 'Match whole word/phrase' option.

match-not-match.jpg

Proposed resolution

Change that portion of the "Match whole word/phrase" UI text to read:
If checked, then the whole word or phrase will be matched, e.g. "book" will not match "book" in "the book".

Remaining tasks

  1. Confirm that the proposed text ("not match") accurately describes the actual behavior.
  2. Review the patch.

User interface changes

Change that portion of the "Match whole word/phrase" UI text to read:
If checked, then the whole word or phrase will be matched, e.g. "book" will not match "book" in "the book".

API changes

None.

Files: 
CommentFileSizeAuthor
#1 feeds_tamper-fix_match_not_match_contradiction_in_find_replace-1928154-1.patch875 bytesfureigh
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch feeds_tamper-fix_match_not_match_contradiction_in_find_replace-1928154-1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

fureigh’s picture

Component:User interface» Plugins
Assigned:fureigh» Unassigned
Status:Active» Needs review
StatusFileSize
new875 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch feeds_tamper-fix_match_not_match_contradiction_in_find_replace-1928154-1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Patch attached, rolled against the master branch.

twistor’s picture

Version:7.x-1.x-dev» 6.x-1.x-dev
Status:Needs review» Patch (to be ported)
twistor’s picture

Issue summary:View changes

Updated remaining steps.

  • twistor committed 752bc0c on 6.x-1.x
    Issue #1928154 by fureigh: Fixed typo in find replace.
    
twistor’s picture

Version:6.x-1.x-dev» 7.x-1.x-dev
Status:Patch (to be ported)» Fixed

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.