Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
What this module lacks is a very basic configurable html wrapper without any appended javascript functionality. It has a group called Div with a very unexpected collapse function. maybe it should be renamed to collapsible or something.
Comments
Comment #1
yannickooMarked #1842472: Plain html wrapper as duplicate because this feature request looks better.
Comment #2
Stalski CreditAttribution: Stalski commentedI think we could just add a config with the most basic display-block wrappers like section, aside, div, ...
Let's summarize them first here and then I'll add it. Defaults to div so we don't break anything for existing implemenations.
Comment #3
Stalski CreditAttribution: Stalski commentedMoving this to 7.x-1.x as the 2 branch is not longer supported.
Comment #4
yannickooSo here is the patch which provides a new group type "HTML element". It provides a textfield for the element, classes and attributes. Attributes are parsed with a regex, then merged with the classes and finally processed with drupal_attributes().
Comment #5
loominade CreditAttribution: loominade commentedExtra CSS classes? seriously? ;)
Comment #6
Stalski CreditAttribution: Stalski commentedthe extra css classes are ment to add extra classes. In last dev, there are some default classes removed (and added in the default extra css classes ;) )
Comment #7
yannickooOh okay, I just wanted create a new issue "Rename 'Extra CSS classes' to 'Extra classes'" but seems like this has been solved. What do you think about the patch Stalski?
Comment #8
lukusI think this is a great idea - would it be used as a substitute for the HTML5 element type that was proposed for the 2.x branch?
Comment #9
yannickooIt is very flexible so we don't need an extra HTML5 elements wrapper for that feature :)
Comment #10
lukus@yannickoo
Thanks a lot for this :) I think it's great — works very well and provides a very good solution to a problem I've been faced with for some time. Would love to see this committed.
One small thing I noticed; if the class is left out, it still inserts a class attribute into the element tag. Maybe the attribute should be removed when a class isn't available?
What further steps need to be taken before this can be committed to dev?
Comment #11
yannickooThank you lukus, you are right that the class attribute is added even if no class is available, I will fix that tomorrow.
I guess that we have to wait for Stalski, he can tell us what is missing for committing the patch/feature.
Comment #12
cesareaugusto CreditAttribution: cesareaugusto commentedIs this patch merged into the dev release?
Comment #13
yannickooNo, that feature isn't in the dev release. There were not commits after 08/12.
Comment #14
cesareaugusto CreditAttribution: cesareaugusto commentedIs the module unmaintained?
Comment #15
yannickooNo, in the issue queue is lot activity. The maintainer is also discussing...
Comment #16
yannickooSo here is the new version. Now the
$group->classes
are trimmed because there is a space at the end by default and that version works fine now :)Comment #17
yannickooWe should use *real* wrappers like div, section, aside etc. Did that in attached patch.
Comment #18
Zach Harkey CreditAttribution: Zach Harkey commentedI tested #17 over on simplytest.me and can verify that it works great.
+1 for this critical feature. It's a no brainer. Being able to designate a group of fields to display as an aside, header, footer, section, figure, etc. is huge.
Comment #19
jlain CreditAttribution: jlain commented+1 - Tested #17 on simplytest.me and works for me.
Comment #20
Hydra CreditAttribution: Hydra commentedI really don't see any reason to not commit this anymore. Thank you very much yanickoo, this is an very nice and needed feature. Comitted and pushed to 7.x-1.x-dev