Default Language_Code for new supporters to current site language

Note: #2108347: Adding Salsa-Translation support already added an initial mapping, although we might want to extend it here and make it configurable as suggested.

+++ b/salsa_entity.module
@@ -232,6 +232,21 @@ function salsa_entity_salsa_object_type_info() {
+ */
+function salsa_entity_entity_presave($entity, $type) {
+  if ($type == 'salsa_supporter') {
+    global $language;
+    $lang_code = SalsaEntityLanguageMapper::toIso639_2();
+    $default_language = variable_get('language_default');
+    $entity->Language_Code = $lang_code ? $lang_code : SalsaEntityLanguageMapper::toIso639_2($default_language->language);
+  }

Should a) only change if the entity is new (no supporter_KEY) and Language_Code is currently empty. We don't want to affect code that re-saves supporters or sets the language code explicitly.

1. +++ b/includes/salsa_entity.language_mapper.inc
   @@ -2,64 +2,73 @@
   -  protected static $code = array(
   -    'de' => 'deu',
   +  protected static $code_mapping = array(
   +    'de' => 'ger',
   

   Strange, how can this be working now for translations? I just confirmed and it is really ger.

2. +++ b/salsa_entity.module
   @@ -232,6 +232,23 @@ function salsa_entity_salsa_object_type_info() {
   + */
   +function salsa_entity_entity_presave($entity, $type) {
   +  if ($type == 'salsa_supporter' && variable_get('salsa_entity_set_supporter_language', TRUE)) {
   +    // Set the code only for supporters that don't have any language code yet.
   

   You can also implement hook_salsa_supporter_presave() directly, saves you one check and doesn't invoke the hook when it's not necessary.

Given that this is pretty crucial and we want to make sure that it doesn't mess up existing data, can we add a basic test for this, you can test 3 scenarios:

a) Save a supporter with the setting disabled, shouldn't set a langcode.
b) Save a supporter with the setting enabled, should set the correct langcode (just making sure that the site default is set is enough, we don't need to test multiple languages)
c) Save a supporter that already has a langcode set and setting enabled, must not overwrite the existing value.

You can do this by testing the API directly, create supporter entities and save them.

Comitted.