Followup from conversation within #1920666: Allow additional external libraries with composer.

This feature would add the ability for testbot to execute a 'composer install' during the installation process for D8 core & contrib modules.

This would likely require a few modifications:
i) formalize the inclusion of drush in testbot (currently, it's really only there as a diagnostic/troubleshooting tool, and could use some updating)
ii) Install/add composer to the testbot build
iii) modifications to the install() method inside review/drupal/pifr_drupal.client.inc

Of course, a next-generation testbot platform which natively supports the running of pre-execute scripts during the build process, where this becomes a test property change instead of an underlying code change, would be preferable. :)

Comments

timmillwood’s picture

Version:6.x-2.x-dev» 6.x-3.x-dev
Assigned:Unassigned» timmillwood
Issue summary:View changes
Status:Active» Needs review
StatusFileSize
new838 bytes

Here's a patch that adds the execution of `composer install` in the core directory.

timmillwood’s picture

StatusFileSize
new861 bytes

Think this would be a better solution

jthorson’s picture

Just as a heads up ... I doubt that composer exists on the current PIFR testbot builds, so that would need to be tackled first.

timmillwood’s picture

@jthorson - It looks like composer is already installed as part of Drush (http://cgit.drupalcode.org/drupaltestbot-puppet/tree/modules/drush/manif...)

This also installs composer_wrapper.sh, I'm happy to take advice and guidance on whether the patch in this issue should be composer install or composer_wrapper.sh install.

jthorson’s picture

Ah ... fantastic! :)

Crell’s picture

I would discourage wrapping stuff around composer if we can avoid it. Same for PHPUnit. Let's keep our PHP-world tools as vanilla as possible; if we need something they can't do, PRs welcome! :-)

timmillwood’s picture

Awesome @crell, sounds good to me.

Is anyone able to get test this patch with testbot?

Mile23’s picture

Is there a similar issue under the DrupalCI project? We really should concentrate effort there.

timmillwood’s picture

@Mile21 - I think there is (but can't find it either) however if this patch can get committed and deployed it will speed things up and we can worry about DrupalCI when it's ready.

Mile23’s picture

Mile23’s picture

Also +1 on #2 patch.

Mile23’s picture

Hmm. Guess I should have done this first.

timmillwood’s picture

Status:Needs review» Closed (won't fix)

Closing as this patch is for the old testbot.