Field description doesn't render on datetime field [#1920778]

As seen in the attached screenshot, showing a node's "authored on" field, the field description is not rendering for the new datetime field.

Here is the code from NodeFormController.php, which plainly includes description text:

    $form['author']['date'] = array(
      '#type' => 'datetime',
      '#title' => t('Authored on'),
      '#description' => t('Format: %format. Leave blank to use the time of form submission.', array('%format' => datetime_format_example($format))),
      '#default_value' => !empty($node->date) ? $node->date : '',
    );

Comment	File	Size	Author
#10	Screen Shot 2014-02-09 at 16.57.55.png	26.7 KB	vijaycs85
#10	Screen Shot 2014-02-09 at 16.58.09.png	26.81 KB	vijaycs85
#5	drupal8.datetime-form.5.patch	701 bytes	sun
#5
#2	1920778-2.patch	477 bytes	swentel
#2
	Screenshot_2_18_13_5_55_PM.png	13.03 KB	jstoller

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

tim.plunkett

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 19 February 2013 at 03:15

Title:

Field discription doesn't render on datetime field

» Field description doesn't render on datetime field

Comment #2

swentel CreditAttribution: swentel commented 21 February 2013 at 20:26

Status:

Active

» Needs review

File	Size
1920778-2.patch	477 bytes

This brings it back, but it's probably not the right approach.

Comment #3

sun

German

Karlsruhe

CreditAttribution: sun commented 22 February 2013 at 18:30

Why isn't #type 'datetime' using the 'form_element' #theme_wrapper? That's the one that handles stuff like #description in all cases.

Comment #4

swentel CreditAttribution: swentel commented 22 February 2013 at 18:38

@sun see

http://drupal.org/node/501428#comment-6902134 (#127)
http://drupal.org/node/501428#comment-7001644 (#133)
http://drupal.org/node/501428#comment-7046752 (#138 - patch)

for reference - it's a usability thing - which doesn't mean it was properly solved ..

Comment #5

sun

German

Karlsruhe

CreditAttribution: sun commented 23 February 2013 at 02:48

File	Size
drupal8.datetime-form.5.patch	701 bytes

Color me confused. I can't see what's wrong with the resulting HTML markup of this patch. I do not see any duplicate HTML labels or anything along those lines.

Comment #7

sun

German

Karlsruhe

CreditAttribution: sun commented 23 February 2013 at 18:38

Ah, thanks, I see. That's still the case.

Which circles back into #1829202: Make #type 'item' work outside of a form context to render a compound label + content

I guess we can go with #2 as a stop-gap fix for now, but yeah, generally not amused about that one-off datetime_wrapper theme function. That's a clear need for a generic wrapper/container/item with label/#title + #description support; i.e., exactly the thing we're working on over there.