We need to create fields only for nodes with enabled commenting or having hidden comments

Files: 
CommentFileSizeAuthor
#1 upgrade-path.patch14.57 KBandypost
upgrade.patch.txt13.44 KBandypost

Comments

andypost’s picture

StatusFileSize
new14.57 KB

Current state

andypost’s picture

It needs profiling and optimizations

andypost’s picture

larowlan’s picture

Status:Active» Needs review

I think we can won't fix this now. Its too late to be considering upgrade path changes imo.
If we create an extra comment field during upgrade for a node type that doesn't have comments enabled, the site admin can just delete it. No harm done.
Thoughts?

andypost’s picture

Suppose some code could be merged to main issue. Also it's ok to wont fix

xjm’s picture

Status:Needs review» Closed (won't fix)

Agreed, this is wontfix. Thanks!