This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for shortcut module.

Schema in place

Schema not yet in place
shortcut.set.default.yml

CommentFileSizeAuthor
#9 schema_patch_8.PNG24.14 KBrahuldolas123
#8 1919198-shortcut-schema-8.patch512 bytesrachit_gupta
#7 1919198-shortcut-schema-7.patch450 bytesvijaycs85
#7 1919198-diff-1-7.txt507 bytesvijaycs85
#1 1919198-shortcut-schema-1.patch408 bytesvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Needs review
FileSize
1919198-shortcut-schema-1.patch408 bytes

Adding schema file...

Status: Needs review » Needs work
Issue tags: -Configuration system, -D8MI, -language-config, -Configuration schema

The last submitted patch, 1919198-shortcut-schema-1.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs work » Needs review

#1: 1919198-shortcut-schema-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Configuration system, +D8MI, +language-config, +Configuration schema

The last submitted patch, 1919198-shortcut-schema-1.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented

Random errors.. re-testing again..

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs work » Needs review

#1: 1919198-shortcut-schema-1.patch queued for re-testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
FileSize
1919198-diff-1-7.txt507 bytes
1919198-shortcut-schema-7.patch450 bytes

Updating labels...

rachit_gupta’s picture

rachit_gupta CreditAttribution: rachit_gupta commented
FileSize
1919198-shortcut-schema-8.patch512 bytes

Updating according to codestyle at http://drupal.org/node/1905070#codestyle

rahuldolas123’s picture

rahuldolas123 CreditAttribution: rahuldolas123 commented
Status: Reviewed & tested by the community » Needs review
FileSize
schema_patch_8.PNG24.14 KB

Hello,

I have tested the above patch with config inspector module and the patch works.
Attaching the screenshot for the same.

image

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs review » Reviewed & tested by the community

Thanks @rahuldolas123. It looks fine to me too.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs review » Reviewed & tested by the community

Committed and pushed to 8.x. Thanks!

Although...

+++ b/core/modules/shortcut/config/schema/shortcut.schema.ymlundefined
@@ -0,0 +1,12 @@
+    id:
+      type: string
+      label: 'ID'

ID is not a mere "string", it is in fact a machine name, and probably ought not to be trifled with (or at the very least ought to have machine name validation). Do we track that as a separate type? If not, should we?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.