This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for rest module.

Schema in place

Schema not yet in place
rest.settings.yml

Files: 
CommentFileSizeAuthor
#3 1919194-rest-schema-3.patch767 bytesvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 50,817 pass(es). View
#3 1919194-diff-1-3.txt445 bytesvijaycs85
#1 1919194-rest-schema-1.patch768 bytesvijaycs85
FAILED: [[SimpleTest]]: [MySQL] 50,434 pass(es), 24 fail(s), and 4 exception(s). View

Comments

vijaycs85’s picture

Status: Active » Needs review
FileSize
768 bytes
FAILED: [[SimpleTest]]: [MySQL] 50,434 pass(es), 24 fail(s), and 4 exception(s). View

Adding schema file...

Status: Needs review » Needs work

The last submitted patch, 1919194-rest-schema-1.patch, failed testing.

vijaycs85’s picture

Status: Needs work » Needs review
FileSize
445 bytes
767 bytes
PASSED: [[SimpleTest]]: [MySQL] 50,817 pass(es). View

Fixing tab issue.

klausi’s picture

Status: Needs review » Needs work

why do we have to specify the schema for the routing settings? Route settings are always the same, so no need for REST module to define their schema. The routing system should define the schema for static routes in YAML, not REST module.

And why are resources of type string? Shouldn't that be an array of strings?

Gábor Hojtsy’s picture

Status: Needs work » Closed (won't fix)

Indeed, if we want to have schemas for *.routing.yml files, that would need to be defined for all of them. Then the rest of rest.module's schema (pun not intended) I'm not sure is needed on the same grounds that sun objected developer only module schemas at the simpletest issue in #1919200: Create configuration schemas for simpletest module. Marking won't fix on the same grounds.