This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for openid module.

Schema in place

Schema not yet in place
openid.settings.yml

CommentFileSizeAuthor
#13 1919188-openid-schema.png24.53 KBsandipmkhairnar
#10 1919188-openid-schema-10.patch472 bytesrvilar
#8 1919188-openid-schema-8.patch473 bytesrvilar
#6 1919188-openid-schema-6.patch474 bytesrvilar
#4 1919188-openid-schema-4.patch651 bytescharmi
#1 1919188-openid-schema-1.patch368 bytesvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Needs review
FileSize
1919188-openid-schema-1.patch368 bytes

Adding schema file...

Status: Needs review » Needs work
Issue tags: -Configuration system, -D8MI, -language-config, -Configuration schema

The last submitted patch, 1919188-openid-schema-1.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs work » Needs review
Issue tags: +Configuration system, +D8MI, +language-config, +Configuration schema

#1: 1919188-openid-schema-1.patch queued for re-testing.

charmi’s picture

charmi CreditAttribution: charmi commented
FileSize
1919188-openid-schema-4.patch651 bytes

Added code and styles in openid module.

Status: Needs review » Needs work

The last submitted patch, 1919188-openid-schema-4.patch, failed testing.

rvilar’s picture

rvilar
Primary language Catalan
Location Montcada i Reixac, Catalonia
CreditAttribution: rvilar commented
Status: Needs work » Needs review
FileSize
1919188-openid-schema-6.patch474 bytes

Attached a new patch to fix the test

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented

Thanks @rvilar, here is some minor label changes:

+++ b/core/modules/openid/config/schema/openid.schema.ymlundefined
@@ -0,0 +1,9 @@
+  type: mapping
+  label: 'Openid text settings'

Can we change "Openid text settings" to "Openid settings"

+++ b/core/modules/openid/config/schema/openid.schema.ymlundefined
@@ -0,0 +1,9 @@
+      type: string
+      label: 'Xri proxy resolver:'

and "proxy resolver for XRI" for this?

rvilar’s picture

rvilar
Primary language Catalan
Location Montcada i Reixac, Catalonia
CreditAttribution: rvilar commented
FileSize
1919188-openid-schema-8.patch473 bytes

New patch with label modifications

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented 
+++ b/core/modules/openid/config/schema/openid.schema.ymlundefined
@@ -0,0 +1,9 @@
+      type: string
+      label: 'Proxy resolver for XRI:'

Can we remove ':' here please?

Also thinking 'Openid settings' might need to be 'OpenID settings'?, but we can leave that to @YesCT or @Gabor.

rvilar’s picture

rvilar
Primary language Catalan
Location Montcada i Reixac, Catalonia
CreditAttribution: rvilar commented
FileSize
1919188-openid-schema-10.patch472 bytes

New patch

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented

for some reasons, I don't see fields in config_inspector.

rvilar’s picture

rvilar
Primary language Catalan
Location Montcada i Reixac, Catalonia
CreditAttribution: rvilar commented

I see them without any problems.

sandipmkhairnar’s picture

sandipmkhairnar CreditAttribution: sandipmkhairnar commented
FileSize
1919188-openid-schema.png24.53 KB

I have reviewed the patche and its working fine.
schema form

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented
Assigned: Unassigned » pfrenssen

Assigning for review.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented
Assigned: pfrenssen » Unassigned
Status: Needs review » Reviewed & tested by the community

I did not see the openid schema either in the configuration inspector, until I enabled the OpenID module :D

Looks good, RTBC!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.