What is the purpose of the In Place editor removing the last panel-separator on line 335 of panels_ipe.js?

It doesn't seem to throw anything off when keeping the last separator in, but causes things to look odd when it is removed in certain cases. I wanted to see if there was a valid reason for it being in place before creating a patch to get rid of the line of code.

CommentFileSizeAuthor
#1 panels-dont_delete_last_panelseperator-1918716-2.patch494 bytesElvar

Comments

Elvar’s picture

Elvar commented
StatusFileSize
new panels-dont_delete_last_panelseperator-1918716-2.patch494 bytes

I second this, also its making the IPE view inconsistent with a normal view, as the last panel-seperator is not removed when IPE is not active. I've added a patch.

Elvar’s picture

Elvar commented
Status: Active » Needs review
d.clarke’s picture

d.clarke commented

I agree. This is causing headaches for us as well for the same reason (inconsistent output between the admin view and anonymous view). It appears this was part of the commit "Implement pane and region locking." (3fd5849), but I don't understand why removing this div is required for the locking functionality.

The patch in the first comment works in my testing.

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
commented
Status: Needs review » Reviewed & tested by the community

#1 works for me as well.

japerry’s picture

japerry
Location KOMK
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Fixed!

http://drupalcode.org/project/panels.git/commit/3ea0757

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit 3ea0757 on 7.x-3.x, 8.x-3.x by japerry: 
    Issue #1918716 by sctteea, Elvar: Remove the IPE last panel separator