A bunch of files in the krumo directory have 755 file permissions. They should probably be 644. Since it's not being included with Composer or anything (and since we're already changing things in it, if memory serves), we should be able to just fix that directly. Patch to follow.

CommentFileSizeAuthor
#1 devel-krumo-file-perms-1918302-1.patch9.36 KBTravisCarden
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden commented
Assigned: TravisCarden » Unassigned
Status: Active » Needs review
FileSize
devel-krumo-file-perms-1918302-1.patch9.36 KB
salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Version: 7.x-1.x-dev » 8.x-1.x-dev

Yes, that makes sense, but we need it for D8 first.

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Status: Needs review » Reviewed & tested by the community

This should apply to all active versions.

eloivaque’s picture

eloivaque
Primary language Catalan
Location Catalan Countries
CreditAttribution: eloivaque commented

I tested the patch #1 and it's works for me.

willzyx’s picture

willzyx CreditAttribution: willzyx commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review

Moving to 7.x since krumo was removed from the 8.x branch in #2620790: Remove Krumo library and Krumo integration from devel

dmitrii’s picture

dmitrii CreditAttribution: dmitrii as a volunteer commented
Status: Needs review » Reviewed & tested by the community

I've tested the patch on the latest 7.x-1.x-dev
The patch result is same as chmod -x $(find ./krumo/ -type f)
No shell scripts permissions are affected.

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Assigned: Unassigned » willzyx

I cannot apply the patch because I develop on Windows. Git for Windows gives me

warning: krumo/... has type 100644, expected 100755

for each file.

Would you apply the patch, willzyx, please? (assuming you're on *nix...)

willzyx’s picture

willzyx CreditAttribution: willzyx commented

patch apply cleanly and solves the issue

Before

user@user:~/devel/krumo$ ls -gG
totale 88
-rwxrwxr-x 1 27398 gen 31 18:57 class.krumo.php
drwxrwxr-x 4  4096 gen 31 18:57 docs
-rwxrwxr-x 1  1286 gen 31 18:57 INSTALL
-rwxrwxr-x 1   439 gen 31 18:57 krumo.ini
-rwxrwxr-x 1  2135 gen 31 18:57 krumo.js
-rwxrwxr-x 1 26925 gen 31 18:57 LICENSE
-rwxrwxr-x 1  4075 gen 31 18:57 README
drwxrwxr-x 7  4096 mar  1  2015 skins
-rwxrwxr-x 1   792 gen 31 18:57 TODO
-rwxrwxr-x 1     6 gen 31 18:57 VERSION

After

user@user:~/devel/krumo$ ls -gG
totale 88
-rw-rw-r-- 1 27398 gen 31 19:00 class.krumo.php
drwxrwxr-x 4  4096 gen 31 19:00 docs
-rw-rw-r-- 1  1255 gen 31 19:00 INSTALL
-rw-rw-r-- 1   419 gen 31 19:00 krumo.ini
-rw-rw-r-- 1  2039 gen 31 19:00 krumo.js
-rw-rw-r-- 1 26421 gen 31 19:00 LICENSE
-rw-rw-r-- 1  3972 gen 31 19:00 README
drwxrwxr-x 7  4096 mar  1  2015 skins
-rw-rw-r-- 1   769 gen 31 19:00 TODO
-rw-rw-r-- 1     6 gen 31 19:00 VERSION

@salvis if you want to commit this patch and you need *nix support let me know :)

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented

if you want to commit this patch and you need *nix support let me know

Yes, please — I can't, on Windows...

TIA, willzyx!

  • willzyx committed 8868652 on 7.x-1.x authored by TravisCarden 
    Issue #1918302 by TravisCarden: Remove executable bits from krumo file...
willzyx’s picture

willzyx CreditAttribution: willzyx commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Assigned: willzyx » Unassigned
Status: Reviewed & tested by the community » Patch (to be ported)

Committed and pushed to 7.x. Thanks!
Moving to 6.x for #3

willzyx’s picture

willzyx CreditAttribution: willzyx commented
Status: Patch (to be ported) » Closed (outdated)

Closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.