Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I have started testing things out in PHP 5.4 and got the following warning when clicking save a draggable view.
Strict warning: Only variables should be passed by reference in draggableviews_handler_fieldapi->set() (line 120 of /usr/www/sites/all/modules/contrib/draggableviews/handlers/draggableviews_handler_fieldapi.inc).
Comment | File | Size | Author |
---|---|---|---|
#4 | draggableviews-remove_php5_4_strict_warning-191416-4.patch | 862 bytes | iStryker |
#3 | 1914166-draggableviews-php54_compat-d7.patch | 637 bytes | NaX |
Comments
Comment #1
iStryker CreditAttribution: iStryker commentedDrupal 7 does not support PHP 5.4, however we should make an effort to fix this.
Thanks @NaX. Let us know if you get any other 5.4 errors.
Comment #2
NaX CreditAttribution: NaX commentedIn the sort term I don't think its critical but according to me "Drupal 7: PHP 5.2.5 or higher " means that 5.4 is supported. http://drupal.org/requirements
If I find any others I will let you know. I have not moved to 5.4 for production sites yet but will be looking to use it on production sites in the next month or so.
If I find some time this week I will look into it and maybe put a patch together.
Comment #3
NaX CreditAttribution: NaX commentedHad a quick look at it and it looks like the use of the reset() function is causing the error. I altered it so that the reset function was not needed and the warning went away.
I hope that helps.
Comment #4
iStryker CreditAttribution: iStryker commentedNaX can you test this patch against. I pulled this code from draggableviews-sort_taxonomy-1851752-1.patch, from #1851752: Drag handler for saving weight into any column in any base table.
I try this new code with a FieldAPI draggableview and it worked.
Comment #5
NaX CreditAttribution: NaX commentedI works great and warnings are gone.
Thanks
Comment #6
NaX CreditAttribution: NaX commentedHas this patch been committed?
Comment #7
iStryker CreditAttribution: iStryker commentedI was going to commit this with a bigger patch that spanned multiple issue, but I have been too busy to finish it. I feel it is safe enough to commit this.
Commited to #4 to 7.x-2.x-dev. f9471c6