Problem/Motivation

Some point while #1751606: Move published status checkbox next to "Save" was being worked on the margin on submit buttons was removed. This makes @webchick angry, and since we can't have an angry @webchick, it needs to be put back.

Proposed resolution

Modify the CSS in both the seven theme and system.theme.css to put a little more breathing room around the submit buttons.

Remaining tasks

this only.

User interface changes

more space around buttons only.

API changes

none.

#1751606: Move published status checkbox next to "Save"

CommentFileSizeAuthor
#11 no_space.png112.97 KBYesCT
#6 core-add_back_spacing_around_submit_buttons-1913112-6.patch383 bytesrcross
#1 core-add_back_spacing_around_submit_buttons-1913112-1.patch772 bytesjenlampton
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
FileSize
core-add_back_spacing_around_submit_buttons-1913112-1.patch772 bytes

Fixes contained in this patch:
- Space between Delete button and cancel link (visible on any confirm form)
- Space between node form Submit drop-button and Preview button

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Status: Active » Needs review

Doh. changing status. need more coffee.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison commented

Looks good to me.

koppie’s picture

koppie CreditAttribution: koppie commented
Status: Needs review » Reviewed & tested by the community

I don't know what it looked like before, but it looks good now. I tested two pages:

  • node/add/page
  • admin/structure/views/add

Both show the correct CSS and look nice too. :-)

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Reviewed & tested by the community » Needs review 
+++ b/core/modules/system/system.theme.css
@@ -141,7 +141,6 @@ abbr.form-required, abbr.tabledrag-changed, abbr.ajax-changed {
-  margin-right: 0;

Hm... I don't see why this requires changes to system.theme.css.

Did you test this with Stark?

rcross’s picture

rcross CreditAttribution: rcross commented
FileSize
core-add_back_spacing_around_submit_buttons-1913112-6.patch383 bytes

Here is a patch for just seven

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs review » Reviewed & tested by the community

I did not manually test the patch, but the diff looks good to me.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

Would be good to have before/after screenshots, but it's probably just fine. Thanks @sun.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x.Thanks all! :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
FileSize
no_space.png112.97 KB

should i open a new issue for...
no_space.png

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue summary: View changes

add more details about proposed changes.