function get_value_options() {
    if (isset($this->value_options)) {
      return;
    }

...

This seems to be simply wrong.
Why return undefined when there is data to return?
Perhaps the following should be more appropriate?

  function get_value_options() {
    if (isset($this->value_options)) {
      return $this->value_options;
    }

...

Comments

dawehner’s picture

Priority: Critical » Minor

You should always populate it, and the code will use the populated value.

Feel free to provide a fix, but this is really not critical.