Add a setStatus() method for configuration entities

+++ b/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.phpundefined
@@ -99,15 +99,26 @@ public function set($property_name, $value, $langcode = NULL) {
+   * @var bool $status

@param

+++ b/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.phpundefined
@@ -99,15 +99,26 @@ public function set($property_name, $value, $langcode = NULL) {
+   * @return \Drupal\Core\Config\Entity\ConfigEntityInterface

Should have a line after it explaining

If we want calling code to be able to rely on enable/disable, they should stay in the interface. So I vote for all three in there.

+++ b/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.phpundefined
@@ -99,15 +99,24 @@ public function set($property_name, $value, $langcode = NULL) {
+   * @return \Drupal\Core\Config\Entity\ConfigEntityInterface
+   *   The class instance that this method is called on.

This @return should be actually on the interface

Well, it should be at least consistent, as you might want to switch out the internal implementation of the class.

Being able to chain stuff is great, so it would makes sense to force it.

+++ b/core/lib/Drupal/Core/Config/Entity/ConfigEntityInterface.phpundefined
@@ -49,6 +49,17 @@ public function enable();
+   * @return \Drupal\Core\Config\Entity\ConfigEntityInterface

Opened #1912544: [policy, then patch] Use @return $this to mark that a method returns itself to make it a bit easier to document what is going on.

Committed to 8.x, thanks! Will push once testbot's calmed down a bit. :)

This patch is causing me local fails due to

Exception Recoverabl ConfigEntityBase.  115 Drupal\Core\Config\Entity\ConfigEnt
    Argument 1 passed to Drupal\Core\Config\Entity\ConfigEntityBase::setStatus()
    must be an instance of Drupal\Core\Config\Entity\bool, boolean given, called
    in
    /Users/alex/dev/sites/drupal8alt.dev/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php
    on line 109 and
    definedDrupal\Core\Config\Entity\ConfigEntityBase->setStatus()
    Drupal\Core\Config\Entity\ConfigEntityBase->disable()
    Drupal\config\Tests\ConfigEntityStatusTest->testCRUD()
    Drupal\simpletest\TestBase->run()
    simpletest_script_run_one_test('2',
    'Drupal\config\Tests\ConfigEntityStatusTest')

Afaik I know scalar's can not be type hinted so:

  /**
   * Implements \Drupal\Core\Config\Entity\ConfigEntityInterface::setStatus().
   */
  public function setStatus(bool $status) {
    $this->status = $status;
    return $this;
  }

should not have the bool

Here's a patch to remove the type hinting.

Please let's also fix the ViewUI class, as it fails pretty hard as well.

Adapting stuff :(

Wrong patch.

doh

Damian pointed out another issue with that.

+1 for that change.

Oops. :\ Sorry, guys.

Committed and pushed to 8.x. Thanks for finding this quickly!!