Support Google's "bounds" parameter

I needed support for filtering as well

#3 For a user it's much nicer/easier to write

  $point = geocoder('google', $locality, array(
    'components' => array(
      'country' => $country,
      'locality' => $locality,
    ),
  ));

instead of (untested)

  $point = geocoder('google', $locality, array(
    'components' => "country=$country|locality=$locality",
    ),
  ));

Once we agree on the format of the parameter I'll reroll for the closure

new patch without closure

Looks good to me, do we need a setting for the components as well?

I was about to open a new feature request when saw your patch and was really happy to see how easy was to do this. I was looking for the region bias (without knowing it) and thought that it would make sense to implement both Bounding Box and region as different bias options, and let the user decide (with a select).

drunken monkey: very sorry for highjacking your issue, not sure if this is good etiquete or just rude. Let me know if you are happy with the result. I did it with the best intention. I would be happy to move my patch to a different issue if you prefer so.

attiks: I wasn't sure about what to do with filters, because they behave in a different way (filtering vs biasing) and because there are different filters available, options form will also be a bit more complex than what is necessary for biasing. How do you see it fit?

Patch attached. Change to needs review, although changes are not really that big

PS: Looking at the patch it seems my texteditor changed some lines (whitespace or tabs, i suppouse)

#12 I'm using this from code, so I have no idea what kind of settings form is needed, I think it will be complex and with not that much of benefits. My use case was to reliably search for cities in certain countries, either by postal code or by city name, without filters I sometimes got strange results, so that's why I added them.

I think we should support both options (as in your patch) but without adding too much settings forms

FYI: the components is rather complex, so no idea if a settings form is desirable, I think most people who are going to use this, will use it from code, docs at https://developers.google.com/maps/documentation/geocoding/#ComponentFil...

I just opened an issue to address this without bloating the interface. #2019419: Adding extra query parameters to google geocoder

May be you can help review it.

#17 Your approach in #2019419: Adding extra query parameters to google geocoder is a bit different, it means you have to construct the query outside of geocoder, making it harder for people to use.

I still think adding an UI for this is off topic and not really needed, but that's just my 2c

Hope you don't mind me weighing in with another subtly different patch. This one also includes support for region biasing and simplifies the UI by putting it into a collapsed fieldset.

However, I have stripped out some of the processing of the options to keep the form simple, which means that people configuring (either by form or code) have to pass in the correctly formatted parameters as per the linked documentation.

#19 no longer applied for me. I have rerolled and attached a new patch.

For adding region biasing to the geofield views plugin: #2155799: Add support for region biasing in views

As a fairly quick addition you can use without patches, this works.

/**
 * Implements hook_url_outbound_alter().
 */
function MODULE_url_outbound_alter(&$path, &$options, $original_path) {
  // Modify reguests to Google geocoder API so we focus on results in the UK.
  if ($path == 'http://maps.googleapis.com/maps/api/geocode/json') {
    $options['query']['region'] = 'UK';
  }
}

Reroll of the patch, setting as RTBC because solves the issue described

Committed. Thanks for the reroll and the review. If you find the time to review other patch, I'd be happy to commit them ;-)

Thanks! :)

Thanks Paul for #22, this works for geofield proximity searching too.

You do need to manually empty the cache_geocoder table in the database, though, to see the improvement.