I have polished the D7 port of Eldir and added a non Aegir branded subtheme "hefring". I would like to contribute these to the project and offer to comaintain this project. I would work on the hefring subtheme and collaborate on the D7 version of Eldir.

My work is available at https://drupal.org/sandbox/skwashd/1907004 Shall I propose a patch?


anarcat’s picture

I am curious to hear how you plan to use the D7 eldir theme ... without Aegir? :)

That would be fine, though. We have been thinking of splitting the hosting/eldir modules back into separate projects for exactly a reason like this...

That would be awesome!

So I guess this first depends on #1468874: Split Eldir back out to a stand-alone project...

anarcat’s picture

The module is now split, should we merge your sandbox as a 7.x-2.x branch in the new theme?

Seems to me hefring should be a separate project...

anarcat’s picture

Assigned: Unassigned » adrian
Status: Active » Needs work

Oh boy.. So I have just remembered now that Steven already *had* ported eldir, as this issue clearly states: #1261030: [meta] Roadmap: Aegir 3.x (D7 port). He built a test harness here: https://drupal.org/sandbox/darthsteven/1267494 - and the main code is still in the D7 branch of hostmaster.

I'll go and extract that back into the eldir module, then we can look at merging your code.

anarcat’s picture

Version: 6.x-0.4-alpha3 » 7.x-3.x-dev
Assigned: adrian » Unassigned
Status: Needs work » Postponed (maintainer needs more info)

Alright, I have pushed the code from hostmaster D7 here, in the 7.x-3.x branch (because the D7 port will be part of Aegir 3).

@skwashd - can you see if you can merge your sandbox with that branch? Otherwise I'll just resolve this issue...

Thanks! And sorry for the mess...

anarcat’s picture

Status: Postponed (maintainer needs more info) » Fixed

So I actually took a look at the port, and it seems that we have everything already in eldir 7.x-3.x. I did import the permission fix from James Harvey (thanks for that!) and it allowed me to notice I forgot a commit, but otherwise I think we're good.

The hefring theme can be a separate project, I believe. Feel free to open a separate issue if you explicitely want it to be shipped with aegir, in which case I'd like to see at least a screenshot or something. :)


anarcat’s picture

Title: Drupal 7 port » Port Eldir to D7
skwashd’s picture

I'll create a patch (with screenshot) against current HEAD for merging hefring into eldir.

Eldir is Aegir branded, while hefring is unbranded. hefring has some other tweaks, it allow the right sidebar to optionally have content. Work is being done to make hefring responsive too. The theme is used as part of the wf_example_profile build for WF Tools.

anarcat’s picture

Shouldn't those improvements be done directly into the Eldir theme?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.