Wrong VAT added to base price [#1905760]

Hi there,

We have a lot of products each with a base price and a discount price (both stored without VAT).
When the discount price is used the base price get the 'discounted' VAT added to it instead of its own. Example:

Product base price: 800 + 25% VAT (200) = 1000.
Discounted price: 400 + 25% VAT (100) = 500.

Shown price: 500 ~~900~~ (save 44%)

It seems to be a bug with discounted products stored without VAT.
Any suggestions?

Comment	File	Size	Author
#10	i1905760-10.patch	1.87 KB	attiks
#7	commerce_price_savings_formatter-correct_original_price-1905760-7.patch	4.62 KB	ordermind
#6	EU_VAT_commerce_price_savings_formatter.patch	1.8 KB	hevmills
#5	fix_EU_vat_base_price_savings_formatter.patch	1.04 KB	Aambro

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

recrit CreditAttribution: recrit commented 8 February 2013 at 18:04

if the VAT is not included in the price, then this module would not add anything to the base price.

I suspect that your rules might need to be reordered to calculate correctly. The VAT pricing rule should fire first and then the discounting rule.

Ensure that the rule "Calculate taxes: VAT" is weighted lighter (lower number) than your discounting rule (higher number).
Ensure that your discounting rule is applying discount as a 'Discount' Price component type and not 'Base Price'

Comment #2

F117 CreditAttribution: F117 commented 10 February 2013 at 14:49

Hi Michael,

Thanks for your reply.
I've tried various rearrangements of the rules, which have given me various issues.

Logically the rules should be arranged as you mention, but this results in a wrong calculated total VAT on the final order overview..
This might correlate to another bug (http://drupal.org/node/1825886).

I've had to tweak the pricing formatter a bit, to get the right result in my case.
Is there a reason we're not using a .tpl.php? Would have been nice regarding the styling.

Comment #3

lodey CreditAttribution: lodey commented 2 September 2013 at 14:36

I have this exact same problem.
The VAT rule should surely be fired after discounts as this gives the true taxable value - at least as required in Britain.
HMRC tax requires VAT to be applied on top of discounted values. When I set up my VAT rule to fire this way I get all the correct values in the checkout summary etc.

The problem appears to be the way the price savings formatter is 're-calculating' the full amount pre discount. It uses the VAT added value, generated after the discount and adds that to the base price, but this will never be correct. Really we want to track what the VAT rate for this product line item is and use that for the calculation. Is it possible to grab hold of that value?

Comment #4

SoftService CreditAttribution: SoftService commented 19 February 2015 at 15:33

Someone has a solution for this please?

Comment #5

Aambro CreditAttribution: Aambro as a volunteer commented 13 August 2015 at 10:40

Issue summary:

View changes

File	Size
fix_EU_vat_base_price_savings_formatter.patch	1.04 KB

I've made a small patch that works for me so far. For me, the base price was wrong, because the module was only checking for "tax_rate" and not "vat_rate". Thus, the savings and percentage were also calculated wrong.

This fixes it.

Comment #6

hevmills CreditAttribution: hevmills as a volunteer and commented 31 March 2016 at 17:54

File	Size
EU_VAT_commerce_price_savings_formatter.patch	1.8 KB

I came across this problem and started working on a solution similar to #5, but found it was adding the VAT calculated from the discounted price, which of course was wrong. I have created another patch here, using elements from the commerce_vat module to calculate the inc vat sale price pre-discount.

It does this by finding all VAT rates in the component, and then applying the highest VAT rate to the base_price.

This seems to work here for me.

Comment #7

ordermind CreditAttribution: ordermind commented 21 June 2016 at 14:08

Status:

Active

» Needs review

File	Size
commerce_price_savings_formatter-correct_original_price-1905760-7.patch	4.62 KB

There is actually a correctly calculated original value already available in commerce_price_savings_formatter_field_formatter_view() so you don't need to reapply taxes there. Basically you can just grab that value and make it a lot more simple.

Comment #8

tijsdeboeck

Antwerp 🇧🇪 🇪🇺 🌎

CreditAttribution: tijsdeboeck at Open Up Media commented 22 August 2016 at 18:12

Patch #5 worked perfect for me, simple & elegant.

I first tried patch #7, but the original values don't exist during checkout, so it showed some notices & didn't display the discounted price ofcourse.

Comment #9

fotograafinge CreditAttribution: fotograafinge commented 2 September 2016 at 08:46

#5 is not working at all for me
#6 is not working right for me (higher original price than the real original price)
#7 is working great for me !! Thank you !!!