Problem/Motivation

All day events are not rendered properly. Create a new all day event. The time its set to 00:00 UTC in the ical feed.

Proposed resolution

N/A

Remaining tasks

Patch creation

User interface changes

N/A

API changes

N/A

Comments

coredumperror’s picture

Title: All day events not handled » All day events not handled properly

Shoot. I didn't write the original all-day rendering code, and I guess I forgot to test it thoroughly.

Does anyone know the correct way to render an all day event in an iCal feed? I don't have time to research solutions right now.

MrSasquatch’s picture

I am experiencing this bug, too, and people on campus are freaking out! I migrated to the 2.x branch of Date iCal to fix some other issues (success), which have now been replaced with this issue. People are complaining that the iCal feeds are now virtually unusable for importing into Outlook, Zimbra, etc, because their calendars are now plastered with 24-hour events, which obscures all their meetings, etc.

Here is an example of the data/time info from our iCal feeds for a particular event...

DTSTART;TZID=America/Chicago:20130220T000000
DTEND;TZID=America/Chicago:20130221T000000

It's supposed to be an all-day event on 2/20/2013, but instead it's a 24-hour event that begins at the beginning of the 20th (midnight) and ends at the beginning of the 21st (the following midnight).

When I do the reverse and duplicate this event manually in Zimbra and export it to a Zimbra-generated ICS file (instead of importing Drupal's ICS into Zimbra), I get the following...

DTSTART;VALUE=DATE:20130220
DTEND;VALUE=DATE:20130221

So it appears that, for an all-day event, the Drupal ICS should just be eliminating the 'T' and anything that follows.

Please help with this! Any assistance is greatly appreciated. If some kind of "sponsorship" payment is required, please just let me know.

MrSasquatch’s picture

Version: 7.x-2.x-dev » 7.x-2.5
Priority: Normal » Major

This is not just affecting dev. This affecting the latest release, 7.x-2.5. I've set the priority to "major," although many people on our campus would tell you this could be considered a "critical" issue. Someone please help fix this bug. Any assistance is greatly appreciated. This is very urgent. Again, if there is an opportunity to pay some sort of sponsorship for this bug fix, please let me know, because we need this fixed ASAP.

coredumperror’s picture

Sorry for the delay on this, folks. I've been laid up in bed with the shittiest cold I've ever heard of for more than a week, and I wasn't even aware of this issue until I finally got back to work today and started reading my email again.

You're right, Sasquatch, this is a very serious issue, and I'll get to work on it as soon as I can today.

coredumperror’s picture

OK, I've committed a change that I'm hoping will fix this problem for everyone. The issue was that the iCalcreator library needs to be specifically told that the DTSTART and DTEND values should be "DATE" rather than the default "DATETIME", when dealing with All Day dates.

Unfortunately, it takes several hours for a pushed commit to get built into a dev release. If you're reading this soon after I posted it, please wait until you see "7.x-2.5+2-dev" as the "Last packaged version" on this page (the +2 is essential) before you get the dev release. The 7.x-2.x-dev release now has this change.

Please download that dev build and let me know if it fixes the problem for you. If it does, I'll tag this build as 7.x-2.6, to get this change pushed out to a new recommended release. If you absolutely need this immediately, though, you can get the fixed build directly from git, by following the instructions on this page.

crifi’s picture

You're the best. Such a support in every module issue queue would be nice. ;-)

I've tested the latest git commit and for my test cases this works perfectly. For me this is RTBC.

MrSasquatch’s picture

@coredumperror, I tried the latest dev, and now my all-day events are showing up as all-day events, not 24-hour events. THANK YOU!!!

coredumperror’s picture

Status: Active » Fixed

I'm glad to hear that. I'll go ahead and push that change out as a new recommended release, 7.x-2.6, which should become available in a few minutes.

Incidentally, I also fixed a bug with importing All Day events, so if you've been using the Feeds importer, that should be working properly now, as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.