Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
who wants it? can we have it?
Comment | File | Size | Author |
---|---|---|---|
#10 | commerce-pricing-attr.jpg | 127.29 KB | nelslynn |
who wants it? can we have it?
Comment | File | Size | Author |
---|---|---|---|
#10 | commerce-pricing-attr.jpg | 127.29 KB | nelslynn |
Comments
Comment #1
nchar CreditAttribution: nchar commentedThanks for your suggestion Christopher! I think that it was a must have feature for this module so I created the functionality of AJAX price refresh immediately. I have committed the changes to the latest release so please try it and confirm that it works.
Comment #2
chriscalip CreditAttribution: chriscalip commentedTested on a sandbox with just a simple commerce setup. This currently works well. Got word from a colleague of mine that on a product display shows multi add2cart commerce forms .. this currently is not working. Testing that data.
Comment #3
chriscalip CreditAttribution: chriscalip commentedTested on a sandbox with a product display with multi add2cart commerce forms -- also currently working. So far so good.
Comment #4
chriscalip CreditAttribution: chriscalip commentedComment #5
nchar CreditAttribution: nchar commentedComment #6
robgreeniowaIn IE8, I'm getting a pop-up message, "An error occurred while attempting to process /system/ajax" whenever the price attempts to change after selecting a differently priced item in the product dropdown. Possibly related to the order of processing ActiveX and XMLHttpRequest?
Comment #7
yannisc CreditAttribution: yannisc commentedComment #8
nchar CreditAttribution: nchar commentedI can't reproduce the error. It works for me in internet explorer 8. It is possible to be caused by another module. Please give me more information.
Comment #9
nelslynn CreditAttribution: nelslynn commentedHere's the issue I'm having with the Ajax price change. To reproduce:
Awesome module otherwise, thanks!
Comment #10
nelslynn CreditAttribution: nelslynn commentedChanging status. See previous post about how to reproduce this bug. Also adding screenshot.
Comment #11
flapsjack CreditAttribution: flapsjack commentedI would also like to add that if you have more than one pricing attribute that it is possible to create a similar ajax bug. If you choose one of the pricing attributes and while the ajax callback is firing, you immediately choose the other option that also changes the price, the second ajax request does the new price calculation based on the current base price. And since the current base price doesn't include the first ajax request change, then you can end up with 2 pricing attributes active, but not have the price reflect the correct combination of both pricing attributes.
I will look at the actual javascript code shortly, but I would assume a simple "running" flag could be set causing subsequent requests to block until the first completes. It seems like serializing the requests should solve this issue.
Comment #12
flapsjack CreditAttribution: flapsjack commentednelslynn,
Since you have done some digging and are familiar with this module, you are probably experiencing or will experience the bug I mentioned here:
http://drupal.org/node/1957076
Basically, the problem is that the pricing attributes stop working when you click the product from the cart and go into "edit" mode. The required commerce product attributes module allows the customer to edit their cart and have all of their customization options remembered. Unfortunately, the pricing attribute options are not properly remembered on edit.
Have you noticed this or are you working around it somehow?
Comment #13
nelslynn CreditAttribution: nelslynn commentedflapsjack,
I'm not allowing the user to edit the product from the cart. The bug you refer to makes it too confusing to the user, so until that is fixed, I'm not allowing a link to the product from the cart. Whether these two issues are related, I don't know.
My bug report pertains to when the user wants to change a product variation (SKU) while still on the product page. The ajax price change does not calculate current selected attribute price into the price display. The price when added to the cart is correct.
Comment #14
AnybodyIs this also working for text fields (custom input)?
I have custom fields for a "length" value that is required for price calculation. Can I else trigger the calculation manually on changing focus?
Comment #15
mikeaja CreditAttribution: mikeaja commenteddeleted
Comment #16
mikeaja CreditAttribution: mikeaja commentedComment #17
mikeaja CreditAttribution: mikeaja commentedComment #18
AnybodyIs there any hint on #14? Any chance to trigger manually via JavaScript? No support for normal text input fields?
Comment #19
mikeaja CreditAttribution: mikeaja commentedThis should be a new feature request. The thread request is fixed.