Files: 
CommentFileSizeAuthor
#1 config-1901988-1-FAIL.patch9.71 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 49,961 pass(es), 3 fail(s), and 2 exception(s). View
#1 config-1901988-1-PASS.patch11.62 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 50,061 pass(es). View

Comments

tim.plunkett’s picture

Priority: Normal » Major
Status: Active » Needs review
Issue tags: -Needs tests
FileSize
11.62 KB
PASSED: [[SimpleTest]]: [MySQL] 50,061 pass(es). View
9.71 KB
FAILED: [[SimpleTest]]: [MySQL] 49,961 pass(es), 3 fail(s), and 2 exception(s). View

This includes the patch from #1889854: Config import breaks on protected entity properties, I'll reroll once that's in.

Since this directly affects all blocks, not just creatively named other entities, bumping to major.

sun’s picture

Well, hrm.

A central problem space here is that you're making the assumption that everything after the config prefix belongs to the ID.

So far, I never wanted to make that assumption — because it will inherently prevent us from horizontally extending config entity objects; i.e., like this:

mymodule.type.foo               « Only this is the entity config.
mymodule.type.foo.enhancement
mymodule.type.foo.ng
...
mymodule.type.foo.othermodule   « Essentially this.
sun’s picture

Status: Needs review » Closed (duplicate)

In essence, this issue + patch duplicates #1831774: Config import assumes that 'config_prefix' contains one dot only

Let's not duplicate that discussion.

tim.plunkett’s picture

I think #2 is a waste, and I can't even comprehend how you propose to make that work.