Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The '--rsyncable' flag is invalid on OS X gzip, and an updated version via homebrew, which means that whenever a backup is created an error occurs, and even worse that error prevents migrating of sites between platforms.
Simple fix for the moment is to remove that flag from backup.provision.inc #90.
Comment | File | Size | Author |
---|---|---|---|
#4 | remove_rsyncable-1901508-4.patch | 495 bytes | Deciphered |
Comments
Comment #1
realityloopThe hombrew patch I wrote has been merged into homebrew-dupes now..
Run the following commands from terminal
Ensure that you don't already have gzip installed via homebrew:
Add hombrew dupes:
Reinstall gzip via homebrew
Comment #2
Deciphered CreditAttribution: Deciphered commentedConfirmed and working.
However, I would still recommend some sort of check to ensure that gzip supports the --rsyncable command before appending it to the command.
Comment #3
Steven Jones CreditAttribution: Steven Jones commentedI'm not sure why we both adding this option anyway, as we don't rsync the same files over and over once they are gzipped.
Could you provide a patch that just removes the use of this option?
Comment #4
Deciphered CreditAttribution: Deciphered commentedDone and done.
Comment #5
omega8cc CreditAttribution: omega8cc commentedNot sure, but I believe there was some reasoning behind this commit, no?
Comment #6
Deciphered CreditAttribution: Deciphered commentedI'm fine for them to be rsyncable if it's necessary, but there really should be some sort of check for anyone who is running a version of gzip that doesn't support this flag, which based on my research wasn't added until after the current stable release of gzip (1.5).
Comment #7
omega8cc CreditAttribution: omega8cc commentedI have checked this on system upgraded from Debian Lenny to Squeeze, so it has
gzip 1.3.12
instead of 1.4, and this version does support --rsyncable option. The fun part is that it is the same version which is used on the latest OS X 10.8.2, but on OS X it doesn't show the --rsyncable option as available, so I guess it is not really gzip version related but OS specific?Comment #8
omega8cc CreditAttribution: omega8cc commentedAnd for the record: http://beeznest.wordpress.com/2005/02/03/rsyncable-gzip/
Comment #9
Deciphered CreditAttribution: Deciphered commentedOk, well I didn't research too hard, so my bad, but the patch we did find that added the flag was rolled against 1.5, and it does work adding the flag to 1.5 for mac (via homebrew).
Regardless, the mac version and the .15 version via homebrew doesn't support the flag and something should be put in place to prevent the flag from being used if it's not supported.
I'll re-roll later tonight.
Comment #10
Steven Jones CreditAttribution: Steven Jones commentedMaybe we need to ask anarcat why he added the commit in question as there's no linked issue with any discussion that I can see?
We aren't changing backup files, so there's no advantage to using this option as far as I can see?
Comment #11
anarcat CreditAttribution: anarcat commentedThe reason why i added --rsyncable is that we use rsync or rsync-like algorithms to backup and move Aegir backups all the time. I figured it would save CPU time, disk IO and bandwidth.
However, as Steven correctly assessed, we probably don't *update* tarballs we have already created, so the effect of this is null. I think we can revert it.
Besides, it would probably explode with hellfire in Solaris and other weird platforms, so let's just ditch this.
Comment #12
thedavidmeister CreditAttribution: thedavidmeister commentedThanks for patch in #14, saved my aegir install from Mountain Lion. Took me longer that I would have liked to find this thread :(
Comment #13
anarcat CreditAttribution: anarcat commentedcommitted, thanks.
Comment #14
realityloopSee comment #1 If your using homebrew on OS X you can get rsyncable support using that method
Comment #15
thedavidmeister CreditAttribution: thedavidmeister commented#14 - you should totally update http://realityloop.com/blog/2012/07/03/nginx-mariadb-php-aegir-mac-os-x-... with the gzip patch
Comment #16
realityloopAdded to step 1