I found that we have wrong code in function themekey_compat_module_implements_alter().

function themekey_compat_module_implements_alter(&$implementations, $hook) {
  if ('custom_theme' == $hook) {
    foreach (variable_get('themekey_compat_modules_enabled', array()) as $module) {
      unset($implementations['$module']); // <== remove quotes.
    }
  }
}
CommentFileSizeAuthor
#2 themekey_compat_admin-module-list.patch621 bytespacufist
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner commented
Version: 7.x-2.3 » 7.x-2.x-dev
Priority: Normal » Major
Status: Active » Fixed

You're right. Committed to git in 7.x-2.x-dev.

pacufist’s picture

pacufist CreditAttribution: pacufist commented
FileSize
themekey_compat_admin-module-list.patch621 bytes

After this patch we should improve admin form. Because modules desapears from list in themekey_compat_settings_form().

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner commented
Status: Fixed » Needs review
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner commented
Status: Needs review » Fixed

sorry, I missied that one. Committed #2 to branches 7.x-2.x and 7.x-3.x. Thanks.

escoles’s picture

escoles CreditAttribution: escoles commented

Could this cause a module or theme to be disabled?

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner commented

Could this cause a module or theme to be disabled?

I don't think so. What's your problem exactly?

escoles’s picture

escoles CreditAttribution: escoles commented

I'm seeing two things happen, that are as far as I can tell unrelated but which look similar, superficially, and started at the same time:

  1. A Views formatting plugin (Views Fluid Grid) is becoming unavailable to Views. (Clearing the 'Page and Else' cache restores it. The module is not disabled.)
  2. A theme is getting disabled. (I.e., it's getting toggled to 'disabled' status.)

When one happens, the other has always happened also, which leads me to think they have the same cause -- though I can't think of anything that would cause either.

I've determined that it's not one causing the other (which would in any case also be quite strange) by disabling the theme and waiting for the views formatter to go away.

I've been comparing to two very similarly-configured sites, and the last difference I could find that seemed like it might make a diff was ThemeKey: It was enabled on the site where I was seeing the problems, not on the other two (a local dev and our production site).

It was in the process of looking again at ThemeKey as a potential cause that I stumbled on this issue. I don't mean to hijack -- if my latest tests (enabling ThemeKey on my dev site to see if I can get a failure) pan out, I'll come back and post an issue.

escoles’s picture

escoles CreditAttribution: escoles commented

(Also have updated to most current version of ThemeKey on the site showing problems. So if I see the problems go away on that site and start to manifest on my local dev site, I will infer that ThemeKey was somehow involved -- though I'll still have no clue how.)

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner commented

Even if ThemeKey should cause the trouble, I'm convinced that it's not related to this issue. So open a new issue (support request) and add as many informations as possible. Which sub-modules of ThemeKey are enabled, your rule chain, ...

escoles’s picture

escoles CreditAttribution: escoles commented

if it looks connected, i will. thanks.

EDIT: ThemeKey does not appear to be contributing to this problem.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.