See #1278146: [META] Ensure all meta tags are supported for missing or incomplete tags required for a 1.0 release.

This ticket is for patches containing code for OpenGraph tags

Files: 
CommentFileSizeAuthor
#11 metatag-n1900434-11.patch7.21 KBDamienMcKenna
PASSED: [[SimpleTest]]: [MySQL] 21 pass(es).
[ View ]
#7 metatag-7.x.1.x-opengraph-1900434-7.patch4.8 KBj0rd
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch metatag-7.x.1.x-opengraph-1900434-7.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#1 metatag-7.x.1.x-opengraph-1900434-1.patch2.31 KBDustin Currie
PASSED: [[SimpleTest]]: [MySQL] 21 pass(es).
[ View ]

Comments

Dustin Currie’s picture

StatusFileSize
new2.31 KB
PASSED: [[SimpleTest]]: [MySQL] 21 pass(es).
[ View ]

Patch containing support for:

og:video
og:video:secure_url
og:video:height
og:video:width
og:video:type

DamienMcKenna’s picture

Title:Support for Open Graph Meta tags» Improve support for Open Graph meta tags
Version:7.x-1.0-beta4» 7.x-1.x-dev
Status:Active» Needs review

Clarified the title.

Status:Needs review» Needs work

The last submitted patch, metatag-7.x.1.x-opengraph-1900434-1.patch, failed testing.

bleen18’s picture

Status:Needs work» Needs review
bleen18’s picture

Status:Needs review» Reviewed & tested by the community

I just played with the patch in #1 and everything looks good. This is certainly a needed addition...

DamienMcKenna’s picture

j0rd’s picture

Title:Improve support for Open Graph meta tags» Improve support for Open Graph meta tags (video & location & contact)
Status:Reviewed & tested by the community» Needs review
StatusFileSize
new4.8 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch metatag-7.x.1.x-opengraph-1900434-7.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

I've added OG Location & Contact information to the original patch.

Since there's no descriptions on Facebook about these fields (and they're pretty self explanatory) I haven't added them in the module.

Status:Needs review» Needs work

The last submitted patch, metatag-7.x.1.x-opengraph-1900434-7.patch, failed testing.

obleser’s picture

Open Graph != Facebook Graph support!

Open Graph definitions could be found here http://ogp.me/

j0rd’s picture

@obleser. Thanks for pointing that out.

I would assume 90% of the people who're using open graph support with this module are using it because they want to support facebook open graph. I hate not following standards as much as the next person, but we're going to need to support the "big players" in this module for it to be useful for site creators.

With that said, I should probably change my facebook specific stuff into another metatag group instead of open graph group, which should remain standard compliant. I'll look into that when I have some time and make sure my patch applies properly for test bot.

DamienMcKenna’s picture

Status:Needs work» Needs review
StatusFileSize
new7.21 KB
PASSED: [[SimpleTest]]: [MySQL] 21 pass(es).
[ View ]

Rerolled and tidied up a little. I replaced the video type text field with a selector to make life easier.

DamienMcKenna’s picture

Assigned:Dustin Currie» Unassigned
Status:Needs review» Fixed

Lets just go with this for now.

DamienMcKenna’s picture

Status:Fixed» Closed (fixed)

Now that Metatag v7.x-1.0-beta5 is out am closing this to keep the issue queue clean.

DamienMcKenna’s picture

Issue summary:View changes

Link ticket