Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Branch tests for the 7.x-1.x branch of the Title module keep failing with the following error:
Failed to run tests: run-tests.sh reported no tests were found. See review log for details..
Tests pass locally with run-tests.sh
. This happens also when testing patches, in fact it seems that after a commit some times the branch tests are green. No idea of what is going on :(
Comment | File | Size | Author |
---|---|---|---|
#2 | title-1900282-2.patch | 290 bytes | plach |
Comments
Comment #0.0
plachUpdated issue summary.
Comment #1
jthorson CreditAttribution: jthorson commentedDouble check your .info file in the test submodule ... you've got
files[] = title_test.module
instead offiles[] = title.test
.Comment #2
plachThanks, didn't notice that!
The
files[]
directive you are suggesting is already present in the parent module, I guess we can skip it altogether.Comment #3
plachCommitted and pushed the patch above, let's see if things are ok now.
Comment #4
plachNope, still getting the error :(
Moreover I saw that the dependency tree has a couple of weird values:
The last stable release of ET is beta2 and has been for a couple of months now.
This module is no required and does not appear anyhere in the .info files.
I'm wondering whether this could be the cuplrit:
Comment #5
plachComment #6
jthorson CreditAttribution: jthorson commentedI tried to rebuild the dependencies via jenkins, but still get the same results. Believe I need to get permissions to the script which removes the project_dependency source code cache, and will come back to this once I get that straightened out.
Comment #7
jthorson CreditAttribution: jthorson commentedThe system line might be messing with something, as I get an empty entry at the end of the dependencies array:
If clearing the sourcecode cache and rebuilding doesn't resolve this, I'll bump it to project_dependency as a bug.
Comment #8
jthorson CreditAttribution: jthorson commentedSame result after clearing the sourcecode cache and rebuilding the dependencies.
Can you try removing the space after the > symbol
dependencies[] = system (> 7.14)
? It looks like the examples at http://drupal.org/node/542202 don't have any spaces after the operators, and if the project_dependency code is assuming no space, that may be what's introducing the extra entries in the dependency array.Comment #9
plachBot green!
Comment #10
plachThanks a lot, Jeremy!
Comment #11
jthorson CreditAttribution: jthorson commentedGood to hear ... I've opened #1905382: Extraneous spaces between operator and versioned dependency result in invalid calculation as a followup.
Comment #12
plachI'm sorry but I have to reopen this :(
The error is still there: a patch review failed reporting no tests were found: http://qa.drupal.org/pifr/test/438173.
By the way I looked to the review log of the dev branch which now is green and the dependency tree still has those wrong values, which I guess are not the culprit then.
Comment #13
Eric_A CreditAttribution: Eric_A commentedSame issue with a Chessboard patch here: http://qa.drupal.org/pifr/test/438708
This is my first test run since the PIFR update.
Comment #14
Eric_A CreditAttribution: Eric_A commentedI realized that the mentioned patch itself probably killed bot class loading. I'll check later, but for now please disregard #13.
Comment #15
jthorson CreditAttribution: jthorson commentedK ... I isolated this test on a bot to do some troubleshooting ... the bot has properly located the test file, and is passing the test request on to simpletest via the following command:
/usr/bin/php ./scripts/run-tests.sh --concurrency 8 --php /usr/bin/php --url 'http://drupaltestbot953/checkout' --file sites/default/modules/title/tests/title.test
It is simpletest which is firing back the error message saying that no tests were found. Can you try executing that test via the run_tests.sh script from drupal root, as follows:
/path/to/php ./scripts/run-tests.sh --url 'http://drupalsite' --file 'path/to/module/tests/title.test'
If you can make that work locally, it should also work on the bots.
Comment #16
plachAs I reported in the OP running the tests from the command line works. I tried to dig in a bit more and this is what I found:
Tests are found and pass.
Tests are not found:
ERROR: No valid tests were specified
.I'm wondering whether this may have anything to do with this issue.
Comment #17
plachI'm wondering whether this may be caused by the fact that the Entity module is required only by tests.
Comment #18
rfayThis actually does *not* work from the command line, contrary to #16. I had the testbot build the whole thing and then ran it manually.
So it's either a problem with the code itself of a problem with drupal core and the run_tests.sh. I do notice using debugs that several of the classes in your .test file do not get loaded into $all_tests (although a couple of them do...)
For your convenience I've provided the full checkout on the testbot and the database provided by the testbot.
Files: https://www.dropbox.com/s/esm4m3m6fm5xeaf/title_test_full_files.tgz
Database: https://www.dropbox.com/s/mlzbb2nj8dqflyz/title_test.sql.gz
Comment #19
plachThanks, I'll see if I can reproduce the errors locally, maybe it's a platform issue, since I'm on windows. If I can't I'll try on an ubuntu box.
Comment #20
plachJust for the record, now tests on the dev branch are green again (I just created a new tagged release).
Comment #20.0
plachUpdated issue summary.
Comment #21
isntall CreditAttribution: isntall at Drupal Association commented