Drupal 6 used hook_perm(). In D7 it was changed to hook_permission().

Attached patch fixes it.

twitter_post-hook_perm.patch530 bytesJohn Franklin
Members fund testing for the Drupal project. Drupal Association Learn more


eosrei’s picture

Version: 6.x-5.0 » 6.x-5.x-dev
Status: Needs review » Needs work

Good catch! Patch doesn't apply to 6.x-5.x-dev. Please clone the repo and make a patch directly from it.

git apply twitter_post-hook_perm.patch 
error: sites/all/modules/twitter/twitter_post/twitter_post.module: No such file or directory
John Franklin’s picture

Are you serious?

eosrei’s picture

I am not the maintainer of this module. I am simply reviewing patches. I know this is an EXTREMELY simple patch, but it doesn't apply correctly. I can easily fix this patch, but per Drupal rules, I cannot RTBC it.

This module has huge number of open issues, far more than the single unpaid regular maintainer (juampy) can review alone. So, please make this simpler/easier for the maintainer and supply patches that correctly apply.

TL;DR: Yes.

juampynr’s picture

Thanks @eosrei ;D

juampynr’s picture

Version: 6.x-5.x-dev » 7.x-5.x-dev
Status: Needs work » Fixed

Fixed. Thanks.

Drave Robber’s picture

Status: Fixed » Needs work

@juampy: instead of fixing 6.x-5.x, you broke 7.x-5.x.

It needs to be twitter_post_perm() in http://drupalcode.org/project/twitter.git/blob/refs/heads/6.x-5.x:/twitt... (6.x) and twitter_post_permission() in http://drupalcode.org/project/twitter.git/blob/refs/heads/7.x-5.x:/twitt... (7.x) - now it's all the way around.

juampynr’s picture

Version: 7.x-5.x-dev » 6.x-5.x-dev
Status: Needs work » Fixed

LOL! Reverted on 7.x-5.x and fixed on 6.x-5.x.


Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.