Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Yet another casualty of the s/name/id patch :(
And it even changed the minimal test coverage we had for it.
Comment | File | Size | Author |
---|---|---|---|
#3 | vdc-1899440-2-FAIL.patch | 1.48 KB | tim.plunkett |
#3 | vdc-1899440-2-PASS.patch | 2.03 KB | tim.plunkett |
#1 | vdc-1899440-1-FAIL.patch | 2.22 KB | tim.plunkett |
#1 | vdc-1899440-1-PASS.patch | 2.77 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettSee attached.
Comment #2
dawehnerYeah another test! Sadly another proove that we can't rely on tests yet while refactor parts of the Views UI. It's still a long way to go.
Beside the points below this looks RTBC from my perspective.
What about creating a test_view_page view, that is the same as test_view but with a page display?
What about putting this into the Views UI group? From here you could guess that this tests the contextual links field in views.
Comment #3
tim.plunkettI don't know why I didn't just put it in the test class that already partially tests this stuff. Makes more sense.
Comment #5
dawehnerNice way simpler!
No need to create another user.
Comment #6
dawehnerI was wrong about that point as the user needs contextual links permission. It's green again, so let's get it in.
Comment #7
catchCommitted/pushed to 8.x, thanks!