Yet another casualty of the s/name/id patch :(
And it even changed the minimal test coverage we had for it.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

Status: Active » Needs review
FileSize
2.77 KB
2.22 KB

See attached.

dawehner’s picture

Yeah another test! Sadly another proove that we can't rely on tests yet while refactor parts of the Views UI. It's still a long way to go.

Beside the points below this looks RTBC from my perspective.

+++ b/core/modules/contextual/lib/Drupal/contextual/Tests/ViewsContextualLinksTest.phpundefined
@@ -0,0 +1,56 @@
+  public static $testViews = array('test_view_storage');

What about creating a test_view_page view, that is the same as test_view but with a page display?

+++ b/core/modules/contextual/lib/Drupal/contextual/Tests/ViewsContextualLinksTest.phpundefined
@@ -0,0 +1,56 @@
+      'name' => 'Contextual: Views display contextual links',
+      'description' => 'Tests contextual links on Views displays.',
+      'group' => 'Views Modules',

What about putting this into the Views UI group? From here you could guess that this tests the contextual links field in views.

tim.plunkett’s picture

I don't know why I didn't just put it in the test class that already partially tests this stuff. Makes more sense.

Status: Needs review » Needs work

The last submitted patch, vdc-1899440-2-PASS.patch, failed testing.

dawehner’s picture

Nice way simpler!

+++ b/core/modules/views/lib/Drupal/views/Tests/UI/DisplayTest.phpundefined
@@ -268,4 +275,15 @@ public function testLinkDisplay() {
+    $this->drupalLogin($this->drupalCreateUser(array('administer views', 'access contextual links')));

No need to create another user.

dawehner’s picture

Status: Needs work » Reviewed & tested by the community

I was wrong about that point as the user needs contextual links permission. It's green again, so let's get it in.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.