I found wrong checking for multiple field on "override" form.

This checking

function _assets_clean_fields(&$form, $options = array()) {
...
      $multiple = isset($elements['#cardinality']) && ($elements['#cardinality'] > 1 || $elements['#cardinality']) == FIELD_CARDINALITY_UNLIMITED;

Should be

function _assets_clean_fields(&$form, $options = array()) {
...
      $multiple = isset($elements['#cardinality']) && ($elements['#cardinality'] > 1 || $elements['#cardinality'] == FIELD_CARDINALITY_UNLIMITED );
...
CommentFileSizeAuthor
#2 wrong-checking-for-multiple-field-1898690-2.patch753 bytesmattew
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

agalitsyn’s picture

agalitsyn CreditAttribution: agalitsyn commented
Status: Active » Closed (fixed)

Pushed to 7.x-1.x-dev

mattew’s picture

mattew CreditAttribution: mattew at Genious Interactive commented
Issue summary: View changes
Status: Closed (fixed) » Patch (to be ported)
FileSize
wrong-checking-for-multiple-field-1898690-2.patch753 bytes

Sorry, I don't know why but this fix is not part of the last beta4, even if the agalitsyn comment date is 31 january 2013 and the last beta4+26 date is 20 february 2013...

And when I browse the repository, the fix is not applied in 7.x-1.x : http://cgit.drupalcode.org/asset/tree/includes/asset.admin.inc#n411

So, there is the patch...

  • IRuslan committed 94ceb04 on 7.x-1.x authored by mattew 
    Issue #1898690 by mattew: Wrong checking for multiple field on "override...
IRuslan’s picture

IRuslan CreditAttribution: IRuslan as a volunteer and at DrupalJedi commented
Status: Patch (to be ported) » Fixed

Pushed to dev branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.