See attached screens.


TwoD’s picture

Title: CKEditor 4 'maximise' leads to edior toolbar displayed under admin_menu toolbar » Administration menu overlaps editors in fullscreen mode
Version: 7.x-2.2 » 7.x-2.x-dev
Component: Editor - CKEditor » User interface
Status: Active » Needs review
3.41 KB

This appears to happen only when the Overlay is used. We've already got the logic in place to hide the standard Toolbar for editors which supports fullscreen modes, so this patch simply adds #admin-menu to the list of elements to show/hide.

danbohea’s picture

Status: Needs review » Reviewed & tested by the community

That patch seems to fix the issue for me. Many thanks.

sun’s picture

Looks good.

As a possible follow-up improvement (in a separate issue), we could investigate to provide central API helper methods for this, in order to decrease the amount of duplicated code.

TwoD’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for the quick review, sorry it took me a month to patch this.

I've committed this to all major branches and the -dev snapshots will be updated within 12 hours and this will be part of the next official releases..

EDIT: Yes, a central utility function sounds good.
Follow-up in #1927000: Add utility functions for fullscreen mode management.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.