This is a follow-up issue from #1497380: Convert shortcut sets to ConfigEntity

There's some code that needs some polish and optimization

Comments

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Title: Clean up shortcut config entity conversion » Add label() method to ShortcutSet
Issue summary: View changes
Issue tags: +Novice

This is the only thing I think that's left. The label() method is necessary when uninstalling the Shortcut module, so that the shortcut set config entities that will be deleted can list their proper names.

illutek’s picture

illutek CreditAttribution: illutek commented
Assigned: Unassigned » illutek

Go here to take a try

michaelfavia’s picture

michaelfavia CreditAttribution: michaelfavia commented
Status: Active » Closed (works as designed)

Could be way off base here but I tested an uninstall on a custom shortcut set and it didn't seem to need the label() method to properly output the shortcut name. Perhaps it is inherited from Entity::label() via ConfigEntity? Please don't hesitate to reopen if I'm missing the point. Just getting my feet wet in D8 again.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

There's some clean-up tasks left to move and deprecate procedural code wrappers to entity methods, but all of them unrelated to subject